Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Content Type when caching API requests #1593

Closed
vanessalove opened this issue May 7, 2015 · 2 comments
Closed

Investigate Content Type when caching API requests #1593

vanessalove opened this issue May 7, 2015 · 2 comments
Labels
closed/wontfix This issue was closed because we have decided not to make the suggested changes kind/bug This issue represents a verified problem we are committed to solving

Comments

@vanessalove
Copy link
Contributor

When enabling caching with HttpClient to interact with your service all requests that are cached are failing to be parsed as JSON due to their Content-Type being text/plain instead of applicaiton/json. I think this is because octopus deploy is setting Content-Type to text/plain in the 304 responses and the cache is being updated to reflect that (or something). In Fiddler I am able to set a rule to modify the requests for our octopus server that removes the Content-Type header for 304 responses and things work fine.

Repro: https://gist.github.com/aarondandy/ee11865494c4b1ea5004
Source: http://help.octopusdeploy.com/discussions/problems/33608

@vanessalove vanessalove added the kind/bug This issue represents a verified problem we are committed to solving label May 7, 2015
@PaulStovell PaulStovell added this to the 3.1 milestone May 26, 2015
@PaulStovell PaulStovell modified the milestones: 3.1, 3.0.2 Jul 17, 2015
@DamianMac DamianMac removed the ready label Aug 26, 2015
@DamianMac DamianMac added the closed/wontfix This issue was closed because we have decided not to make the suggested changes label Nov 13, 2015
@DamianMac
Copy link

We're likely going to rebuild the http API piece in the near future.

@lock
Copy link

lock bot commented Nov 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot unassigned DamianMac Nov 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed/wontfix This issue was closed because we have decided not to make the suggested changes kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

3 participants