Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible options for action conditions based on the tenant for the deployment #3337

Closed
michaelnoonan opened this issue Mar 24, 2017 · 3 comments
Assignees
Labels
closed/wontfix This issue was closed because we have decided not to make the suggested changes feature/run-condition feature/tenants kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time

Comments

@michaelnoonan
Copy link
Contributor

michaelnoonan commented Mar 24, 2017

The main pain-point this resolves is a decision we made around whether an action will run for a particular deployment based on the Deployment.TenantId which can either be a Tenant, or null (for an untenanted deployment). In this case the customer wanted to run a step for untenanted deployments, and any tenanted deployments where the tenant matched a certain filter.

As of Octopus 3.4, if you add a tenant filter to an action we automatically exclude that step for any untenanted deployments.

A picture is worth a few extra words:

image

Source: http://help.octopusdeploy.com/discussions/questions/11037

@pawelpabich
Copy link

Variable Based Run Condition feels like the right tool for the job here. In this way we can keep the UI simple. What do you think @michaelnoonan ?

@droyad droyad added the closed/wontfix This issue was closed because we have decided not to make the suggested changes label May 3, 2019
@TomPeters
Copy link

There are many combinations of things that people want to base the run conditions off: environments, tenants, machines, roles and channels all come to mind. Instead of implementing this feature (which may end up being very complex in order to cover all possible types of scopes), we think it will be better to rely on the existing framework we have for varying your deployment across different scopes: Variables.

Specifically we think that Variable based run conditions can solve this problem in a simpler way. Some enhancements to Variable based run conditions may be required to cover all use cases (eg see #3206).

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed/wontfix This issue was closed because we have decided not to make the suggested changes feature/run-condition feature/tenants kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Development

No branches or pull requests

4 participants