Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticationProviders load configuration from the SQL Database on every HTTP Request #3354

Closed
michaelnoonan opened this issue Mar 29, 2017 · 3 comments
Assignees
Labels
feature/performance kind/bug This issue represents a verified problem we are committed to solving
Milestone

Comments

@michaelnoonan
Copy link
Contributor

Performance profiling shows we are loading configuration for the authentication providers from the SQL database on every HTTP Request. It looks like the source of this behaviour is https://github.com/OctopusDeploy/OctopusDeploy/blob/master/source/Octopus.Server/Web/Api/GlobalRules/MaintenanceModeRule.cs#L32

It is only building a whitelist of URLs - we should just get the list from "loaded" providers, not necessarily enabled ones.

Relates to #3311

@michaelnoonan michaelnoonan added area/scale kind/bug This issue represents a verified problem we are committed to solving labels Mar 29, 2017
@michaelnoonan michaelnoonan self-assigned this Mar 29, 2017
@michaelnoonan
Copy link
Contributor Author

@octoreleasebot octoreleasebot added this to the 3.11.17 milestone Apr 2, 2017
@octoreleasebot
Copy link

Release Note: Fixed a performance issue with the maintenance mode check, in turn removing some load from the SQL Database for every HTTP request

@lock
Copy link

lock bot commented Nov 23, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/performance kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

2 participants