Saving IIS related steps created by previous version of Octopus fails

[NickJosevski]

Issue

If the bindings are stored as a pipe delimited set when you add to the set or remove from it, save fails with a console error on bindingsToString.

Old style binding: http:#{httpPort}://#{UseStandardHttpBinding}/false when parsed host is undefined.

Solution

A new migration Script0092MigrateIisBindingsToJson that reads entire DeploymentProcess table, looking in Steps -> Actions -> Properties -> Octopus.Action.IISWebSite.Bindings, it ignores any that are new style, already have the indicator of starting as a JSON array is empty [] or start of populated set [{.

A new BindingEntry is built up from the split up of the pipe delimited string, following how Calamari does it in this conditional branch of code.

Test cases

In test function: CleanupBindingsCheck_Script0092MigrateIisBindingsToJson

• Unit tests with crafted steps containing old style

  • 2 taken from customers reporting issue
  • 1 hand crafted

• Compared Database pre migration with post migration (Script0092MigrateIisBindingsToJson)

During testing, reviewed changes to the entire document, only changes were by design.

[NickJosevski]

This related to #3752

The plan is to write a data migration script so the v1 parser and anything else can go away, and stop biting us.

[NickJosevski]

Migration script for bindings old storage format

[pawelpabich]

@NickJosevski, I think we can close this one off ?

[NickJosevski]

@pawelpabich yes it will be fixed for customers when they install v4 and Script0093MigrateIisBindingsToJson runs, same goes if they run the migrator and go to v4.

[NickJosevski]

Release Note: Fixed error that occurs when saving IIS related project steps that were created by earlier versions of Octopus

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.