Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how wildcards work for purge custom directory #3786

Closed
johnsimons opened this issue Sep 11, 2017 · 6 comments
Closed

Clarify how wildcards work for purge custom directory #3786

johnsimons opened this issue Sep 11, 2017 · 6 comments
Assignees
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Milestone

Comments

@johnsimons
Copy link

johnsimons commented Sep 11, 2017

In:
image

the help text:

A newline-separated list of file or directory names, relative to the installation directory, to leave 
when it is purged. Extended wildcard syntax is supported. 
E.g., appsettings.config, Config\*.config, **\*.config

could be more clear on when to use wildcards

Raised by customer in https://help.octopusdeploy.com/discussions/questions/12996-exclude-from-purge-iis-templateperformance-hit

@johnsimons johnsimons added the kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time label Sep 11, 2017
@droyad droyad added this to the 4.0 milestone Sep 12, 2017
@NickJosevski NickJosevski removed this from the 4.0 milestone Sep 13, 2017
@larssb
Copy link

larssb commented Sep 13, 2017

I'm the customer that raised the issue. It would be wonderful with some kind of warning/explanation that wildcards should only be used to match on files not folders (to include all files in a folder).

Thank you.

@pawelpabich pawelpabich added this to the 4.0 milestone Sep 14, 2017
@droyad droyad changed the title Better help text to clarify wildcard usage Clarify how wildcards work for purge custom directory Oct 10, 2017
@droyad
Copy link
Contributor

droyad commented Oct 19, 2017

@johnsimons @larssb How does this sound? (Bold added to show the added text)

A newline-separated list of file or directory names, relative to the installation directory, to leave
when it is purged. To exclude a whole directory, specify it by name without a wildcard. Extended wildcard syntax is supported. E.g., appsettings.config, Config\.config, Config, **\.config

@droyad
Copy link
Contributor

droyad commented Oct 19, 2017

image

@droyad droyad self-assigned this Oct 19, 2017
@droyad
Copy link
Contributor

droyad commented Oct 19, 2017

Release Note: Clarified how to exclude directories when purging a custom installation directory

@droyad droyad closed this as completed Oct 19, 2017
@larssb
Copy link

larssb commented Oct 19, 2017

Sounds good to me :-)

@lock
Copy link

lock bot commented Nov 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Development

No branches or pull requests

5 participants