Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Authentication Provider method #3834

Closed
droyad opened this issue Oct 3, 2017 · 4 comments
Closed

Remove deprecated Authentication Provider method #3834

droyad opened this issue Oct 3, 2017 · 4 comments
Assignees
@michaelnoonan
Labels
tag/breaking-change The resolution of this issue introduced a deliberately breaking change
Milestone
4.0.0

Comments

@droyad
Copy link
Contributor

droyad commented Oct 3, 2017 •
edited

This method was deprecated as part of https://github.com/OctopusDeploy/OctopusDeploy/issues/390 in https://github.com/OctopusDeploy/OctopusDeploy/pull/847 (3.12.0)

Authentication providers targeting the old method CreateAuthCookie(NancyContext, Guid, bool) will no longer work and need to be upgraded. Use CreateAuthCookies(Request, Guid, SessionExpiry) instead.
@droyad droyad self-assigned this Oct 3, 2017
@droyad droyad added this to the 4.0 milestone Oct 3, 2017
@droyad droyad added the tag/breaking-change The resolution of this issue introduced a deliberately breaking change label Oct 3, 2017
@droyad
Copy link
Contributor Author

droyad commented Oct 3, 2017

Not sure what benefit removing this method has over just keeping the overload (see PR). @michaelnoonan ?

@droyad droyad removed their assignment Oct 3, 2017
@michaelnoonan michaelnoonan self-assigned this Oct 4, 2017
@droyad
Copy link
Contributor Author

droyad commented Oct 4, 2017

After discussion, this method will not set the CSRF cookie, and that is why we are removing it. This will result in a MissingMethodException for plugins still using this method.

@droyad
Copy link
Contributor Author

droyad commented Oct 4, 2017 •
edited by michaelnoonan

Release Note: Breaking Change The NancyCookie AuthCookieService.CreateAuthCookie() used by custom authentication providers has been replaced with NancyCookie[] AuthCookieService.CreateAuthCookies(). This will only impact customers who have written custom authentication providers.

@droyad droyad closed this as completed Oct 4, 2017
@lock
Copy link

lock bot commented Nov 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaelnoonan michaelnoonan

Labels
tag/breaking-change The resolution of this issue introduced a deliberately breaking change
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@michaelnoonan @droyad