New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a tenant is passed to the URL after clicking deploy, we should not pre-fill tenant tags from the release channel. #4322

Closed
danielfischeroctopus opened this Issue Feb 26, 2018 · 2 comments

Comments

Projects
None yet
5 participants
@danielfischeroctopus

danielfischeroctopus commented Feb 26, 2018

Currently if you select to deploy to a Tenant from the project overview the Tenant Tags associated with the releases channel are pre-filled. This can cause you to accidentally deploy to multiple tenants when only selecting a single tenant to deploy to.

We should not pre-fill any tenant tags when the tenant is already defined in the URL.

Source: https://help.octopusdeploy.com/discussions/questions/12228

Steps to replicate:

Create a Tenant tag-set with two tags.
Set up two Tenants. (Tenant-A & Tenant-B)
Apply one tag to each tenant

Set up a simple Tenanted project.
Create a Channel with both above tags.
Create a release for said channel but do not deploy.
Go to the project overview.
Select to deploy to a single Tenant.

You will find that the Channels tags for both Tenant-A & Tenant-B are pre-selected, alongside the Tenant you have selected to deploy, as this is already defined in the URL.

Example:
Select to deploy to Tenant-B

Tenant Tags A & B predefined alongside Tenant-B

On this page the URL has defined which tenants to deploy and auto populated that field, the channels tenant tags should not auto fill as this by default will deploy Tenant-A & Tenant-B if you do not notice.

OCTOPUSSERVER/app#/projects/tenant-channels-filter/releases/0.0.30/deployments/create/to/Environments-1/Tenants-2

Extra points:

Add a Tenant tag C. Scope tag C to Tenant-A. (Tenant-A should have two tags now A&C.)
Create another release.
Select to Deploy release
Deploy to Tag-B + Tag-C (Tag-C is not in the Channel)
This will deploy Tenant-A & Tenant-B.

@TomPeters TomPeters closed this Mar 5, 2018

@octoreleasebot octoreleasebot added this to the 2018.2.9 milestone Mar 5, 2018

@octoreleasebot

This comment has been minimized.

octoreleasebot commented Mar 5, 2018

Release Note: Fixed a bug where the tenant tags would be pre-filled on the create deployment page if you had navigated to a create deployment url for deploying to specific tenants

@tw17 tw17 modified the milestones: 2018.2.9, 2018.3.0 Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment