Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upcomming RegisterApplicationTypeTimeoutSec parameter in Service Fabric SDK #4496

Closed
mcasperson opened this issue Apr 19, 2018 · 8 comments
Assignees
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Milestone

Comments

@mcasperson
Copy link

Publish-NewServiceFabricApplication is calling Register-ServiceFabricApplicationType as part of the service fabric deployment, but there is no way to set the timeout for Register-ServiceFabricApplicationType.

The issue at microsoft/service-fabric-issues#347 indicates that Publish-NewServiceFabricApplication will gain a new parameter called RegisterApplicationTypeTimeoutSec that will allow a timeout to be set. This timeout should then be something we expose to resolve errors like the one described at https://secure.helpscout.net/conversation/562991622?folderId=1380316.

@slewis74
Copy link

Another report https://secure.helpscout.net/conversation/591051539/27588/

Looks like this is actually available now, so implementation could go ahead on our side

@slewis74 slewis74 added the kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time label May 31, 2018
@octoreleasebot
Copy link

Release Note: Added RegisterApplicationTypeTimeoutSec to Service Fabric deploy step

@BharathRahulDS
Copy link

This is still persisting.

@johnsimons
Copy link

@benPearce1 this seems to be done?

@benPearce1
Copy link

@BharathRahulDS Can you please provide some more information about any issues you might be receiving?

@johnsimons
Copy link

We support this timeout now in the step, closing this.

@lock
Copy link

lock bot commented May 8, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Development

No branches or pull requests

6 participants