Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment api response does not include link to the deployment process #4835

Closed
matt-richardson opened this issue Aug 24, 2018 · 2 comments
Closed
Assignees
Milestone

Comments

@matt-richardson
Copy link
Contributor

Calling /api/deployments/Deployments-6878 returns:

{
  "Id": "Deployments-6878",
  "ReleaseId": "Releases-2210",
  "EnvironmentId": "Environments-81",
  "TenantId": null,
  "ForcePackageDownload": false,
  "ForcePackageRedeployment": false,
  "SkipActions": [],
  "SpecificMachineIds": [],
  "ExcludedMachineIds": [],
  "DeploymentProcessId": "deploymentprocess-Projects-501-s-4-XXGLW",
  "ManifestVariableSetId": "variableset-Deployments-6878",
  "TaskId": "ServerTasks-36069",
  "ProjectId": "Projects-501",
  "ChannelId": "Channels-501",
  "UseGuidedFailure": false,
  "Comments": null,
  "FormValues": {},
  "QueueTime": null,
  "QueueTimeExpiry": null,
  "Name": "Deploy to Production",
  "Created": "2018-04-27T00:23:28.838+00:00",
  "Links": {
    "Self": "/api/deployments/Deployments-6878",
    "Release": "/api/releases/Releases-2210",
    "Environment": "/api/environments/Environments-81",
    "Project": "/api/projects/Projects-501",
    "Task": "/api/tasks/ServerTasks-36069",
    "Web": "/app#/deployments/Deployments-6878",
    "Artifacts": "/api/artifacts?regarding=Deployments-6878",
    "Interruptions": "/api/interruptions?regarding=Deployments-6878",
    "Variables": "/api/variables/variableset-Deployments-6878"
  }
}

Its odd that it includes DeploymentProcessId, but not a link to it.

You can get to it by going to the Release link, and then the ProjectDeploymentProcessSnapshot link, but its a bit of a pain (side note, its called ProjectDeploymentProcessSnapshotId on the releases object, not DeploymentProcessId, which is a bit interesting.)

I propose we add a DeploymentProcess link to the deployment api response.

@octoreleasebot
Copy link

Release Note: Added DeploymentProcess link to deployment api response

@lock
Copy link

lock bot commented Nov 23, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants