Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable specificity not working with multiple tenant tags. #5277

Closed
5 tasks done
danielfischeroctopus opened this issue Feb 7, 2019 · 6 comments
Closed
5 tasks done
Assignees
Labels
closed/wontfix This issue was closed because we have decided not to make the suggested changes

Comments

@danielfischeroctopus
Copy link

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

Variable specificity not working as expected with Tenant Tags. Variable scoping is not selecting the most specific value when multiple Tenant Tags apply.

What I expected to happen

If I have two variable values, one scoped to a Tenant Tag, the second scoped to Two Tenant tags. If I deploy to a Tenant which has both tags, I would expect the more explicitly tagged variable value to be used.

Steps to reproduce

  1. Create Tenant & Tag Set with two tags. Tag-A & Tag-B Apply Both tags to Tenant.
  2. Create Project w/ multi value project variable. foo & bar - Connect project to Tenant
  3. Scope variable foo to Tag-A
  4. Scope variable bar to Tag-A & Tag-B
  5. Create deployment to Tenant by specifying Tag-A & Tag-B

It should be expected that the value bar is used for the variable, as we deployed to the Tenant by specifying a combination of both Tenant tags, however we do not seem to be correctly applying variable specificity when deploying to multiple Tenant tags.

Screen capture

Source ticket with screenshot: https://secure.helpscout.net/conversation/757086339/38102?folderId=845288

Affected versions

Tested in LTS 2018.10.2

@danielfischeroctopus danielfischeroctopus added kind/bug This issue represents a verified problem we are committed to solving area/modelling labels Feb 7, 2019
@mbotting
Copy link

mbotting commented Feb 8, 2019

Being able to preview which variables will be used per tenant in a deployment would assist with this also. At the moment you have to run the deployment to see what gets applied which isn't great in production

@droyad
Copy link
Contributor

droyad commented Feb 11, 2019

I disagree that this is a bug. This is the same situation as a machine that is in multiple roles. See https://octopus.com/blog/variable-specificity-and-complexity for the reasoning.

Also the fact the deployment is created using specific tags (step 5 above) is not relevant as that just selects the tenants for which to create deployments.

@NickJosevski
Copy link

Tenant Tags were designed as a query language to help locate and select the applicable Tenants for a given deployment.

We currently have no plans to increase the complexity of the specificity determination of variables to have them factor in matching tenant tags.

I pinged the customer who was linked to this.

@NickJosevski NickJosevski self-assigned this Mar 19, 2019
@NickJosevski NickJosevski added closed/wontfix This issue was closed because we have decided not to make the suggested changes and removed kind/bug This issue represents a verified problem we are committed to solving labels Mar 19, 2019
@octoreleasebot
Copy link

1 similar comment
@octoreleasebot
Copy link

@OctopusDeploy OctopusDeploy deleted a comment from octoreleasebot Mar 20, 2019
@lock
Copy link

lock bot commented Jun 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed/wontfix This issue was closed because we have decided not to make the suggested changes
Projects
None yet
Development

No branches or pull requests

5 participants