Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes step doesn't quote label values correctly #5979

Closed
5 tasks done
slewis74 opened this issue Nov 6, 2019 · 2 comments
Closed
5 tasks done

Kubernetes step doesn't quote label values correctly #5979

slewis74 opened this issue Nov 6, 2019 · 2 comments
Assignees
Labels
feature/kubernetes kind/bug This issue represents a verified problem we are committed to solving
Milestone

Comments

@slewis74
Copy link

slewis74 commented Nov 6, 2019

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

When an integer is entered as a label value it ends up in the yaml as an integer and gets interrupted as such down the line. This has lead to problems where strings are expected.

What I expected to happen

The values should be quoted, as the Annotations are.

Affected versions

Octopus Server:

Workarounds

None

Links

Raised internally.

@slewis74 slewis74 added kind/bug This issue represents a verified problem we are committed to solving feature/kubernetes labels Nov 6, 2019
@slewis74 slewis74 closed this as completed Nov 6, 2019
@octoreleasebot octoreleasebot added this to the 2019.10.5 milestone Nov 6, 2019
@octoreleasebot
Copy link

Release Note: Fixed an issue with the Kubernetes step not correctly quoting label values

@lock
Copy link

lock bot commented Feb 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/kubernetes kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

2 participants