Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid request submitted to Team API can cause denial of service #6005

Closed
matt-richardson opened this issue Nov 14, 2019 · 2 comments
Closed
Assignees
Labels
kind/bug This issue represents a verified problem we are committed to solving
Milestone

Comments

@matt-richardson
Copy link
Contributor

matt-richardson commented Nov 14, 2019

If a malformed request is submitted to the Team API, for either create or modify, the save is successful. However, the code that reads the team data isn't expecting the invalid data and hits a null reference exception.

Without that cache the server APIs cannot load permissions and return an error for all incoming requests. It isn't possible to create this situation through the portal, only through the API.

CVE: CVE-2019-19376

Relates to OctopusDeploy/OctopusDeploy#4740

@matt-richardson matt-richardson added the kind/bug This issue represents a verified problem we are committed to solving label Nov 14, 2019
@matt-richardson
Copy link
Contributor Author

@octoreleasebot octoreleasebot added this to the 2019.10.6 milestone Nov 14, 2019
@matt-richardson matt-richardson changed the title Placeholder issue Invalid request submitted to Team API can cause denial of service Nov 28, 2019
@lock
Copy link

lock bot commented Feb 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

2 participants