Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email targets do not handle trailing semicolons #6081

Closed
5 tasks done
matt-richardson opened this issue Jan 2, 2020 · 2 comments
Closed
5 tasks done

Email targets do not handle trailing semicolons #6081

matt-richardson opened this issue Jan 2, 2020 · 2 comments
Assignees
Labels
kind/bug This issue represents a verified problem we are committed to solving
Milestone

Comments

@matt-richardson
Copy link
Contributor

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

A user added a trailing semicolon to the bcc field for an email step, which caused the email step to fail. Our logic does not handle this case.

What I expected to happen

Trailing semicolons, commas, spaces etc should be ignored.

Steps to reproduce

  1. Create a project
  2. Add a "send email step"
  3. set the "to" address to "test@example.com;"
  4. Deploy the release
    --> error An invalid character was found in the mail header: ,`

Affected versions

Octopus Server: ~3.0.19

Workarounds

Remove the trailing semicolon

Links

source: customer ticket (private link)

@matt-richardson matt-richardson added the kind/bug This issue represents a verified problem we are committed to solving label Jan 2, 2020
@matt-richardson matt-richardson self-assigned this Jan 2, 2020
@octoreleasebot octoreleasebot added this to the 2019.11.2 milestone Jan 3, 2020
@octoreleasebot
Copy link

octoreleasebot commented Jan 3, 2020

Release Note: Handled trailing semicolons in the address field of the send email step

@lock
Copy link

lock bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

2 participants