Octopus.Client JSON mismatch

[PaulStovell]

Adding a new console app and installing Octopus.Client and running results in an exception - the JSON.NET that we compile against is older than the one NuGet installs. We probably need to put a binding redirect in or something.

[nblumhardt]

NuGet should already add the binding redirect when Octopus.Client is installed, but binary incompatibility between JSON.NET versions will still affect us unless we specify a version range.

Is the error something like MissingMethodException?

[PaulStovell]

Unhandled Exception: System.IO.FileLoadException: Could not load file or assembly 'Newtonsoft.Json, Version=4.5.0.0, Culture=neutral, PublicKeyToken=3
0ad4fe6b2a6aeed' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT
: 0x80131040)
   at Octopus.Client.OctopusClient..ctor(OctopusServerEndpoint serverEndpoint)
   at Octopus.Client.OctopusRepository..ctor(OctopusServerEndpoint endpoint) in c:\TeamCity\buildAgent\work\1116bd9da9e239fd\source\Octopus.Client\Oct
opusRepository.cs:line 52
   at VariableImporter.Program.Main(String[] args) in c:\Users\Paul\Documents\Visual Studio 2013\Projects\VariableImporter\VariableImporter\Program.cs
:line 16

[PaulStovell]

In case anyone comes across this via a search, the workaround is to add a binding redirect like this:

<?xml version="1.0" encoding="utf-8" ?>
<configuration>
    <startup> 
        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5" />
    </startup>
  <runtime>
    <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
      <dependentAssembly>
        <assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
        <bindingRedirect oldVersion="0.0.0.0-6.0.0.0" newVersion="6.0.0.0" />
      </dependentAssembly>
    </assemblyBinding>
  </runtime>
</configuration>

Where newVersion=6.0.0.0 should be replaced with whatever version of Json.NET that you are referencing.

[PaulStovell]

Going to close this as I don't think it's a good idea for us to be adding binding redirects when apps might already use other versions of Json.NET.

[nblumhardt]

Commit above is unrelated to this - typo.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.