Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The runbook run preview page makes a request per tenant #7269

Closed
droyad opened this issue Dec 16, 2021 · 2 comments
Closed

The runbook run preview page makes a request per tenant #7269

droyad opened this issue Dec 16, 2021 · 2 comments
Assignees
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time p3 state/backlog On the backlog (2/4)

Comments

@droyad
Copy link
Contributor

droyad commented Dec 16, 2021

Problem

A customer reported that they were seeing really slow performance on the runbook run preview page when there were dozens (or 100's) of tenants. We found that a request was being made per tenant every time the tenant filter criteria got changed. This request takes a long time so they build up.

Steps to reproduce:

  1. Create a project with a thousand tenants and a few tags that link them up. (or use this script).
  2. Create a runbook on the project
  3. Setup a run of the runbook, select the tenants by tags. Note the number of requests increase and overlap as you select more and more tags.

Proposed Solution

The deployment preview page does not have this problem as it retrieves the same data in a single call. We should do the same for runbooks.

@droyad droyad added kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time team/fire-and-motion labels Dec 16, 2021
@droyad droyad added the state/backlog On the backlog (2/4) label Jan 6, 2022
@zentron zentron added the p3 label Feb 22, 2022
@N-lson N-lson self-assigned this May 4, 2022
@N-lson N-lson closed this as completed May 29, 2022
@octoreleasebot
Copy link

Release Note: Improve performance of runbook run preview page when selecting tenants

@Octobob
Copy link
Member

Octobob commented Aug 29, 2022

🎉 The fix for this issue has been released in:

Release stream Release
2022.3 2022.3.755
2022.4+ all releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time p3 state/backlog On the backlog (2/4)
Projects
None yet
Development

No branches or pull requests

5 participants