Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PUT /dashboardconfiguration restore default settings when called with no request payload #7833

Closed
6 tasks done
long-sean opened this issue Oct 10, 2022 · 2 comments
Closed
6 tasks done
Assignees
Labels
area/core kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time state/happening Currently in progress (4/4)

Comments

@long-sean
Copy link

Prerequisites

  • I have searched open and closed issues to make sure it isn't already requested
  • I have discussed this in #feature-discussion or #backlog and the consensus is that this is something we plan on adding in the near future
  • I have written a descriptive issue title
  • I have linked the original source of this feature request
  • I have labelled the value stream (area/core, area/steps, ...)
  • I have added the kind/enhancement label

The enhancement

Change the PUT /dashboardconfiguration response contract by not returning an error message for requests without a payload/body

What is the problem this solves or benefit it gives

  • More consistent endpoint behaviour
  • Default settings can be restored by a request with an empty request body

Proposed solution

The current validation which returns a "No request body" error message will not be ported over to ASP when this endpoint is converted during project-nancyfx-migration

@long-sean long-sean added kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time state/happening Currently in progress (4/4) labels Oct 10, 2022
@long-sean long-sean self-assigned this Oct 10, 2022
@long-sean
Copy link
Author

Release Note: Make PUT /dashboardconfiguration restore default settings when called with no request payload instead of returning a "No request body" error message

@Octobob
Copy link
Member

Octobob commented Nov 8, 2022

🎉 The fix for this issue has been released in:

Release stream Release
2022.4 2022.4.4586
2023.1+ all releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time state/happening Currently in progress (4/4)
Projects
None yet
Development

No branches or pull requests

2 participants