Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage worker lease cap as a system variable #8218

Closed
veochen-octopus opened this issue Jun 23, 2023 · 3 comments
Closed

Manage worker lease cap as a system variable #8218

veochen-octopus opened this issue Jun 23, 2023 · 3 comments
Assignees
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time

Comments

@veochen-octopus
Copy link

veochen-octopus commented Jun 23, 2023

We added an environment variable (OCTOPUS__WorkerLeases__LeaseCap) to help some of the deployment steps spread across more workers. We were hoping that this would help us determine what would be a good default value so we can eventually get rid of the variable. It became obvious that there is no such a value for all customers. There are valid cases for no distribution, full distribution (round robin) and anywhere in between. So the variable is here to stay. And an env var is too clumsy for that. We should add a system variable for it, which has the added benefit of being self-serve and applying to individual projects rather than the whole instance.

Relates to #7569

@veochen-octopus veochen-octopus added the kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time label Jun 23, 2023
@octoreleasebot
Copy link

Release Note: Add variable Octopus.Deployment.WorkerLeaseCap to manage worker lease cap

@veochen-octopus
Copy link
Author

The new system variable is called Octopus.Deployment.WorkerLeaseCap. Docs to follow.

@Octobob
Copy link
Member

Octobob commented Aug 22, 2023

🎉 The fix for this issue has been released in:

Release stream Release
2023.1 2023.1.11423
2023.2 2023.2.12643
2023.3 2023.3.5093
2023.4+ all releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Development

No branches or pull requests

3 participants