Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeploying a tenanted release and including tenants that already have that release creates a deployment even if selecting to skip tenants with that release #8272

Closed
hnrkndrssn opened this issue Aug 1, 2023 · 2 comments
Assignees
Labels
kind/bug This issue represents a verified problem we are committed to solving

Comments

@hnrkndrssn
Copy link

Severity

UI confusion, unnecessary deployments created

Version

All versions, code hasn't changed since introduced

Latest Version

I could reproduce the problem in the latest build

What happened?

When redeploying to a single Tenant, the Skip tenants where <version> is the current version deployed to <environment> doesn't seem to work as expected.

What I expected: If ticked, and the Tenant is already running the current version, there should be no deployment created.

What happens: When ticked, and the Tenant is already running the current version, a deployment is created anyway. This is confusing because I'm not sure why the box is ticked if it doesn't take effect

Reproduction

Create a project
Create an environment
Attach a tenant to the project and environment
Create a release
Deploy the release to the environment
Select to redeploy the release to the same environment
Select the tenant
Observe deploy button is enabled and preview shows that a deployment will be created for the tenant

Error and Stacktrace

No response

More Information

No response

Workaround

No response

@hnrkndrssn hnrkndrssn added the kind/bug This issue represents a verified problem we are committed to solving label Aug 1, 2023
@hnrkndrssn hnrkndrssn self-assigned this Aug 1, 2023
@octoreleasebot
Copy link

Release Note: Fix redeploy tenanted release issue where the option to skip tenants where release is current for a tenant isn't available after explicitly selecting tenants

@Octobob
Copy link
Member

Octobob commented Aug 22, 2023

🎉 The fix for this issue has been released in:

Release stream Release
2023.1 2023.1.11970
2023.2 2023.2.13175
2023.3 2023.3.11120
2023.4+ all releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

3 participants