Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Co-Operative cancellation: Complete Script is not given enough time to terminate. #8570

Closed
LukeButters opened this issue Jan 22, 2024 · 2 comments
Assignees
Labels
kind/bug This issue represents a verified problem we are committed to solving

Comments

@LukeButters
Copy link

Severity

No response

Version

2024.1.4557

Latest Version

I could reproduce the problem in the latest build

What happened?

When cleaning up a script on tentacle and it takes longer than 1 minute for cleanup to complete, an error message: Failed to cleanup the script working directory on Tentacle is logged.

That error message is misleading since what is actually happening is:

  • Tentacle will complete the cleanup operation.
  • Octopus Server falsely logs it failed.

Reproduction

Create a script which creates lots of files in its working directory on a host with slow IO causing the cleanup operation to take more than 1 minute.

Error and Stacktrace

No response

More Information

OctopusDeploy/OctopusTentacle#770

Workaround

No response

@LukeButters LukeButters added the kind/bug This issue represents a verified problem we are committed to solving label Jan 22, 2024
@LukeButters LukeButters self-assigned this Jan 22, 2024
@octoreleasebot
Copy link

Release Note: Fixes a bug in which Octopus may not have waited long enough for scripts run on tentacle to be cleaned up, resulting in a misleading message that the cleanup failed when it may succeed. OctopusDeploy/OctopusTentacle#770

@Octobob
Copy link
Member

Octobob commented Feb 19, 2024

🎉 The fix for this issue has been released in:

Release stream Release
2024.1 2024.1.8598
2024.2+ all releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

3 participants