Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ScopedUserRole to use Entity Framework #8685

Closed
rosslovas opened this issue Mar 14, 2024 · 2 comments
Closed

Convert ScopedUserRole to use Entity Framework #8685

rosslovas opened this issue Mar 14, 2024 · 2 comments
Assignees
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time

Comments

@rosslovas
Copy link

Are you a customer of Octopus Deploy? Don't raise the issue here. Please contact our support team so we can triage your feature request, making sure it's handled appropriately.

The Need

From Target Architecture Blog Post:

We're on a journey to better normalize Octopus's database schema. Doing so will unlock the ability to solve many known performance and concurrency issues.

We initially thought we could achieve a good deal of this normalization using our current ORM, Nevermore.

As we dug into the problem with a team, we found problems we'd need to solve in Nevermore to use it as the tool to meet our normalization needs. This was particularly an issue for loading and querying data across multiple database tables that might back a single logical model.

The team then evaluated the cost of solving these problems in Nevermore against the cost of migrating to a tool that could already do these things, like Entity Framework.

Moving to Entity Framework was already in our plans, as we want to use commodity tools for most common things. However, we originally thought we could delay the cost of the migration to achieve our more immediate goals sooner.

After we disproved this assumption, we realized moving to Entity Framework sooner was the better option. We updated the target architecture accordingly, and we're now deep into the work of moving ORMs in the core of Octopus.

Solution

Migrate ScopedUserRole to use Entity Framework

Links

Target Architecture Blog Post

@rosslovas rosslovas added the kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time label Mar 14, 2024
@rosslovas rosslovas self-assigned this Mar 14, 2024
@octoreleasebot
Copy link

Release Note: Converted ScopedUserRole document persistence from JSON store to relational model.

@Octobob
Copy link
Member

Octobob commented May 16, 2024

🎉 The fix for this issue has been released in:

Release stream Release
2024.2 2024.2.2764
2024.3+ all releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Development

No branches or pull requests

3 participants