Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nevermore BeginReadTransaction method does not create a SQL transaction and therefore will not hold a transaction name #165

Open
akirayamamoto opened this issue Sep 14, 2021 · 0 comments

Comments

@akirayamamoto
Copy link
Contributor

akirayamamoto commented Sep 14, 2021

I was writing some tests and found out that BeginReadTransaction method does not create a transaction and therefore will not hold a transaction name.

I could only find references to BeginReadTransaction on Octofront so Octopus Server is not affected.

I see these options for us:

  • Change the Nevermore behavior to actually open a transaction when calling such method. This could cause lock issues on Octofront.
  • Change the method name to something like BeginConnection instead so we are not expecting a transaction.

Tests here: #162
See related PR: #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant