Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startSignalRHub(hub) produces @ngrx/signalr/error + double @ngrx/signalr/disconnected #26

Open
GeorgBreithaupt opened this issue Mar 15, 2021 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed need reproduction Issue that require a reproduction repository

Comments

@GeorgBreithaupt
Copy link

Hi!

Thanks for that great work.

I have a problem with action startSignalRHub(hub).

When I call startSignalR(hub), it dispatch 3 actions:

@ngrx/signalr/error
@ngrx/signalr/disconnected
@ngrx/signalr/disconnected

Any idea?

Thanks!

@Odonno
Copy link
Owner

Odonno commented Oct 1, 2022

Hi @GeorgBreithaupt

I am not aware of this issue. In order to fix this issue, is it possible for you to provide a reproduction repository?

@Odonno Odonno added bug Something isn't working help wanted Extra attention is needed need reproduction Issue that require a reproduction repository labels Oct 1, 2022
@GeorgBreithaupt
Copy link
Author

Sorry, it was described wrong: it's not startSignalRHub but stopSignalRHub. Then always comes

  • signalrError
  • signalrDisconnected
  • signalrDisconnected

Thank you!

image

@vulzee
Copy link
Contributor

vulzee commented Mar 8, 2023

I ran into same issue.
On connection close there is an error populated
this._connection.onclose((error) => { this._errorSubject.next(error); this._stateSubject.next(disconnected); });
and the error subscription
const errorSubscription = this._errorSubject.subscribe(() => { observer.error(new Error('The connection has been closed.')); });
in 'on' function throws an error before the observer.complete(); on line 108.

Maybe it's about the order of this events?

@Skynet5d
Copy link

Hi @Odonno,

First, thank you for the job you have been doing for this lib.

We just encountered the same issue today, when calling stopSignalRHub, it raises the error "The connection has been close".

Is it an issue that will be addressed soon?

Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed need reproduction Issue that require a reproduction repository
Projects
None yet
Development

No branches or pull requests

4 participants