Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you know what happens if a request to connect to signalR takes longer than 10 seconds? #83

Closed
labeled opened this issue Sep 30, 2022 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed need reproduction Issue that require a reproduction repository

Comments

@labeled
Copy link

labeled commented Sep 30, 2022

We're using your default reconnect policy and noticing sometimes that when a request to connect hangs for longer than 10 seconds it seems to get stuck in a forever loop trying to reconnect even though state shows the status as connected.
It might be that timer() queues up the next event before the first one has finished.

@Odonno
Copy link
Owner

Odonno commented Oct 1, 2022

takeUntil(actions$.pipe(ofType(signalrConnected), ofHub(action)))

As per this line, the reconnect should abort when the hub finally connects. So if it does not, the reconnect effect is indeed stuck in a loop.

I don't see why it would still try to reconnect when the hub is connected. Is it possible for you to provide a reproduction repository?

@Odonno Odonno added bug Something isn't working help wanted Extra attention is needed need reproduction Issue that require a reproduction repository labels Oct 1, 2022
@Odonno
Copy link
Owner

Odonno commented Oct 1, 2022

Per #37 issue and since v14.1.0, you can now use automatic reconnect provided by the @microsoft/signalr library. Check the readme file to see how it works.

@labeled
Copy link
Author

labeled commented Oct 1, 2022

Per #37 issue and since v14.1.0, you can now use automatic reconnect provided by the @microsoft/signalr library. Check the readme file to see how it works.

Thank you for this! We will more than likely start using that!

@Odonno Odonno closed this as completed Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed need reproduction Issue that require a reproduction repository
Projects
None yet
Development

No branches or pull requests

2 participants