Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter SDK routing #417

Open
tzarebczan opened this issue May 17, 2022 · 0 comments
Open

Smarter SDK routing #417

tzarebczan opened this issue May 17, 2022 · 0 comments
Labels
type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@tzarebczan
Copy link
Contributor

When an SDK goes down, it still has calls routed through it, which makes for a poor app experience and for any apps relying on it (i.e. livestreamer)

The goal would be to make sure the status is properly reflected for app users and then stop routing any new calls until the SDK is healthy again.

For users with wallets, we'll use the status call to show them a warning about some account related things not working. Something we noticed recently with KP is that single resolve calls (happen on content pages and a few other areas) always have wallet data appended to them, so those would always fail. We probably don't want to do that, and can add the additional params (include purchase receipt / include protobuf) only in specific cases . Don't recall what protobuf is used for.

@tzarebczan tzarebczan added the type: improvement Existing (or partially existing) functionality needs to be changed label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

1 participant