Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in velocity #63

Open
rocketnik opened this issue May 28, 2021 · 2 comments
Open

Bug in velocity #63

rocketnik opened this issue May 28, 2021 · 2 comments

Comments

@rocketnik
Copy link
Contributor

rocketnik commented May 28, 2021

Please take a look at
if velocity.y < 100 { /// dragging up
It should be
if velocity.y < -100 { /// dragging up

As I understand this is for fast dragging which should always select the next point in direction of the drag instead of find the closes point, which could mean going back a bit.

Having the sheet almost closed (dragged to bottom) and then moving slightly (not matter if up or down) of speed of 5 or -5, it will be below 100 and interpreted as fast drag up, which it is not. It would be a drag up, if velocity was negative and it would be a fast drag up, if velocity was below -100.

@OfTheWolf
Copy link
Owner

@rocketnik That's correct. Also /// dragging up, down comments are misleading and should be removed.

@rocketnik
Copy link
Contributor Author

To my understanding the comments are correct. Maybe add the word “fast” before “drag”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants