Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Signed transaction should pay for the cost of verifying their signature #138

Closed
edfelten opened this issue Jul 16, 2020 · 3 comments
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@edfelten
Copy link
Contributor

ArbOS has to pay the cost of a signature verification for every signed transaction. The transaction should be charged for the gas needed to do that. A simple way to do this would be to deduct the cost of an ecrecoverinstruction from the transaction's gas, when we first set up gas-charging for the transaction.

Also, before checking a transaction's signature, we should verify that it has requested enough gas to pay for its signature check. If it hasn't, we should fail the transaction before even checking the signature.

@edfelten edfelten added bug Something isn't working enhancement New feature or request labels Jul 16, 2020
@edfelten edfelten self-assigned this Jul 16, 2020
@edfelten
Copy link
Contributor Author

The cost should be charged to the party responsible for submitting the signed message. This is because we don't want to do the signature check until we know it has been paid for, and we don't know who the signer is until we check the signature. So the submitter (typically the aggregator, but in case of a signed batch of messages it will be the batch signer) needs to get charged.

@edfelten
Copy link
Contributor Author

We're going to treat this as low priority because we don't think this will be a serious DoS vector.

@edfelten
Copy link
Contributor Author

Closing this, because the new fee model accounts for the cost of signature verification. It's included in the network fee.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant