-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack warnings #92
Comments
I have a fix for this but I'm running into trouble with the unit tests working with the treeshaking added to the tsx files. |
@millerds do you mind sharing your fix even if the unit tests aren't working? |
I created a draft PR of what the changes consist of at #97. The end to end tests pass, but the unit tests fail because of the more specific import statements. I didn't have any luck figuring out a change that would keep the tests, and haven't been able to spend much time on it recently. |
Even more so I would expect to not see:
in particular not for MSFT office related packages. |
When are you seeing that message? |
that various packages are not up-to-date (part of MSFT core products) in particular:
I am talking in particular also about the Azure related libraries like:
|
I think part of the problem is that the vendor code is being included in both the vendor bundle and the taskpane bundle. |
Expected behavior
When running
npm run build
with nothing added to the basic template I expected to get no warnings about the bundle sizesCurrent behavior
I get these warnings
Steps to Reproduce
Please provide detailed steps for reproducing the issue.
npm run build
Context
Failure Logs
The text was updated successfully, but these errors were encountered: