New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comand-line build instructions clarification #533
Closed
Closed
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
26a7716
Edit OpenXmlBasePart property comment (fixes #511) (#528)
Xyaneon ffe30a8
clarify command-line build instructions
1f4935f
Merge branch 'master' of https://github.com/tomjebo/open-xml-sdk
5717e04
Merge branch 'master' into master
twsouthwick 2e2a14b
fixes to build instructions
17a85ed
more refinement on build instructions and corrections. also link to t…
caec6d2
Merge branch 'master' into master
twsouthwick d884f37
Merge branch 'master' into master
twsouthwick 8e04825
Merge branch 'master' into master
twsouthwick bb36a81
ProjectLoadStyle=All requires msbuild
c41c299
Merge remote-tracking branch 'upstream/master'
2ace80f
Merge branch 'master' of http://github.com/tomjebo/Open-XML-SDK
e71b03e
Merge branch 'master' of http://github.com/tomjebo/open-xml-sdk
b6adbc5
Merge branch 'master' into master
twsouthwick File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -144,10 +144,14 @@ To build the Open XML SDK | |
|
||
If you want to use a command line approach: | ||
|
||
1. Go to the directory that contains the solution. | ||
1. Run `dotnet restore` in the directory. | ||
1. Run `dotnet test DocumentFormat.OpenXml.Tests` to run the tests. | ||
1. Run `dotnet pack DocumentFormat.OpenXml` to generate a nupkg. | ||
* Go to the directory that contains the solution. | ||
* Run `dotnet restore` in the directory (only if using .NET Core SDK version less than 2.1). | ||
* Run `dotnet test DocumentFormat.OpenXml.Tests.csproj` to run the tests. | ||
* Run `dotnet pack .\src\DocumentFormat.OpenXml\DocumentFormat.OpenXml.csproj` to generate a nupkg. | ||
* Run `dotnet build` to build the SDK and test projects | ||
|
||
By default, `dotnet` will build/test/run only the .NET Core target framework. To build all target frameworks, set the ProjectLoadStyle environment variable: `ProjectLoadStyle=All` To see the other values for `ProjectLoadStyle`, please refer to the comments in [Directory.Build.Props](Directory.Build.Props). NOTE: Because the other frameworks will be targeted (like .NET 4.6) when using `ProjectLoadStyle=All`, msbuild.exe is needed instead of dotnet.exe so refer to [appveyor.yml](appveyor.yml) to see the appropriate command lines. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's actually only because of .NET 3.5; .NET 4.0+ works fine with the dotnet cli. Also, the |
||
|
||
|
||
Related tools | ||
------------- | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's actually only because of .NET 3.5; .NET 4.0+ works fine with the dotnet cli. Also, the
.exe
isn't really needed, and is technically incorrect on *nix platforms.