Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): cycle depedencies batch 1 #11619

Merged
merged 14 commits into from
May 17, 2024
Merged

fix(core): cycle depedencies batch 1 #11619

merged 14 commits into from
May 17, 2024

Conversation

jayzhang
Copy link
Member

@jayzhang jayzhang commented May 15, 2024

fix: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/28068421

  1. clean up unused codes
  2. resolve cycle depedency issues in fx-core (common/tools.ts, etc.)
  3. optimize and clasify utility files

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 93.61949% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 88.41%. Comparing base (5d4a696) to head (1fa3f83).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #11619      +/-   ##
==========================================
+ Coverage   88.40%   88.41%   +0.01%     
==========================================
  Files         536      535       -1     
  Lines       32659    32615      -44     
  Branches     6352     6329      -23     
==========================================
- Hits        28871    28836      -35     
+ Misses       1842     1836       -6     
+ Partials     1946     1943       -3     
Files Coverage Δ
packages/cli/src/commands/models/provision.ts 93.75% <100.00%> (-0.37%) ⬇️
packages/fx-core/src/common/globalState.ts 86.66% <100.00%> (ø)
...ackages/fx-core/src/common/local/taskDefinition.ts 71.73% <100.00%> (ø)
packages/fx-core/src/common/m365/launchHelper.ts 86.11% <100.00%> (ø)
packages/fx-core/src/common/m365/packageService.ts 91.75% <100.00%> (ø)
packages/fx-core/src/common/samples.ts 94.59% <100.00%> (ø)
packages/fx-core/src/common/tools.ts 89.39% <100.00%> (+11.15%) ⬆️
packages/fx-core/src/common/utils.ts 71.42% <100.00%> (ø)
packages/fx-core/src/component/constants.ts 100.00% <100.00%> (ø)
...ackages/fx-core/src/component/coordinator/index.ts 87.59% <100.00%> (-0.03%) ⬇️
... and 62 more

... and 1 file with indirect coverage changes

@jayzhang jayzhang merged commit 86935a1 into dev May 17, 2024
32 checks passed
@jayzhang jayzhang deleted the huajie/fixcycle1 branch May 17, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet