fix: check vscode.version to enable teams participant #11621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alive-Fish
requested review from
1openwindow,
HuihuiWu-Microsoft,
nliu-ms,
tecton,
LongOddCode,
Siglud,
qinezh and
wenytang-ms
as code owners
Alive-Fish
force-pushed
the
zhiyou/version-check
branch
from
5f88e40
to
d337084
Compare
Alive-Fish
force-pushed
the
zhiyou/version-check
branch
from
d337084
to
e81418c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #11621 +/- ##
==========================================
- Coverage 88.40% 88.40% -0.01%
==========================================
Files 536 536
Lines 32659 32664 +5
Branches 6352 6356 +4
==========================================
+ Hits 28872 28876 +4
- Misses 1842 1843 +1
Partials 1945 1945
|
tecton
reviewed
May 16, 2024
| @@ -189,11 +189,11 @@ jobs: | |||
| git commit -m "build: replace sideloading placeholders" | |||
|
|
|||
| - name: disable chat participant environment variable | |||
| if: ${{ github.event_name == 'workflow_dispatch' && (github.event.inputs.preid != 'alpha') }} | |||
| if: ${{ github.event_name == 'workflow_dispatch' && (github.event.inputs.preid != 'alpha' && github.event.inputs.preid != 'beta') }} | |||
There was a problem hiding this comment.
It seems that the script could be removed since we use function instead of const variable?
There was a problem hiding this comment.
If we need to hide them in the stable release TTK, we also need to check the preid.
tecton
approved these changes
May 17, 2024
LongOddCode
approved these changes
May 17, 2024
wenytang-ms
approved these changes
May 17, 2024
This was referenced May 17, 2024
LongOddCode
pushed a commit
that referenced
this pull request
May 17, 2024
* fix: check vscode.version to enable teams participant * fix: cd adjustment * fix: ff for sample gallery * fix: cd content --------- Co-authored-by: Yuqi Zhou <yuqzho@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/28055653