Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect validation in AttachmentCollection #20

Open
Noblebrown opened this issue Sep 2, 2014 · 0 comments
Open

Incorrect validation in AttachmentCollection #20

Noblebrown opened this issue Sep 2, 2014 · 0 comments
Labels

Comments

@Noblebrown
Copy link

In AttachmentCollection.addItemAttachment(Class), a check is performed to see if the class is attachable. It checks to see if the class has any declared fields, which is incorrect as Class.getDecaredFields() will not return inherited fields and there are attachable classes that do not declare their own fields, but rely on those in parent classes. There is an @attachable annotation that is present on all attachable objects. It should be checking against this instead.

@vboctor vboctor added the bug label Sep 2, 2014
@vboctor vboctor changed the title Bug: Incorrect validation in AttachmentCollection Incorrect validation in AttachmentCollection Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants