Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated manifest doesn't show up in catalog #107

Closed
abkieling opened this issue Nov 19, 2015 · 6 comments
Closed

Generated manifest doesn't show up in catalog #107

abkieling opened this issue Nov 19, 2015 · 6 comments

Comments

@abkieling
Copy link
Contributor

The following optional element doesn't have a valid value and is causing the app to not show up in the catalog for installation:

<SupportUrl DefaultValue="[Support URL]"/>

I would like to suggest this element to be removed or generated with a valid value. I understand the value is supposed to be changed, but it would be great if the generated manifest is 100% valid to avoid problems for beginners. Word doesn't indicate the issue, it just doesn't list the app in the catalog.

@andrewconnell
Copy link
Contributor

Would be nice to have all non-required elements removed... want to do it and submit a PR @alexkieling ?

@abkieling
Copy link
Contributor Author

OK, I'll do it.

@waldekmastykarz
Copy link
Contributor

Although the SupportUrl is not required for deploying Office Add-ins to your own App Catalog, it is required if you would like to publish your Add-in in the Office Store (https://msdn.microsoft.com/en-us/library/office/jj220035.aspx). If we just removed all optional properties it would mean that developers who want to publish their Add-ins to the Office Store will get a few surprises.

What if we could add a gulp task that would validate the manifest against the Office Store guidelines? That way we could keep deployment to own App Catalogs easy and help out devs who want to publish Add-ins in the Office Store.

@abkieling
Copy link
Contributor Author

We could keep it commented out, like this:

<!-- Support URL is required for add-ins submitted to the Office Store
<SupportUrl DefaultValue="[Support URL]"/>
-->

@andrewconnell
Copy link
Contributor

I prefer to have the generator only include the absolutely required properties, but yes having a task that could validate for store submission would be nice. I don’t think the majority of add-ins are going to be submitted to the store so we shouldn’t have that be the default.

@waldekmastykarz
Copy link
Contributor

OK, let's remove all optional parameters from the manifest and I'll add a new issue for new store validation task so we can track it separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants