Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the validateHighResolutionIconUrl function to check for valid image URL #112

Closed
waldekmastykarz opened this issue Dec 5, 2015 · 4 comments

Comments

@waldekmastykarz
Copy link
Contributor

We should extend the _validateHighResolutionIconUrl function in the generated gulpfile.js to check if the specified URL is a valid image URL (extension ending with .png or .jpg). Currently we only check if the specified URL is an https URL. The problem with that is that if you provide a non-image URL (eg. https://contoso.com), your add-in will work as expected in OWA but won't show up in Outlook client which is almost impossible to track back to the URL specified in the HighResolutionIconUrl property in the manifest. If we could check for it, it would be very helpful for the developers.

@andrewconnell
Copy link
Contributor

👍

@waldekmastykarz
Copy link
Contributor Author

Shall I pick it up after we merge PR #111 into main to avoid merge issues given that a fix for this will modify the same files?

@andrewconnell
Copy link
Contributor

Go for it

@waldekmastykarz
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants