Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App not updating profile picture with badge #10

Closed
UnknownNamez opened this issue Apr 14, 2021 · 24 comments
Closed

App not updating profile picture with badge #10

UnknownNamez opened this issue Apr 14, 2021 · 24 comments
Assignees
Labels
enhancement New feature or request

Comments

@UnknownNamez
Copy link

UnknownNamez commented Apr 14, 2021

Hi,
we successfull installed the App at our tenant and everything works fine except the update profile picture function. We didn't customized anything just used the default app. All API Requests are granted!

PS: Downloading your own profilpicture works!

ChampionPlatform_Error

@UnknownNamez UnknownNamez changed the title App not updating profilpicture with badge App not updating profile picture with badge Apr 14, 2021
@yhabersaat
Copy link
Contributor

yhabersaat commented Apr 19, 2021

Errors related:

clb-home-web-part_b1cbeaebdb2dfe4d2fc7493714d6d706.js:1 getPhotoBits error: SecurityError: Failed to execute 'toBlob' on 'HTMLCanvasElement': Tainted canvases may not be exported

clb-home-web-part_b1cbeaebdb2dfe4d2fc7493714d6d706.js:1 _updateUserPhoto error: TypeError: Cannot set property 'lastModifiedDate' of undefined

As I see, there is an issue with _getCanvasBlob() in the DigitalBadge.tsx file which involves the second error but there is a mention in a comment that it's not working at the moment.

@Smitat-msft
Copy link
Contributor

@yhabersaat @UnknownNamez Thanks for being patient. Looks like a permission issue. let me repro and get a resolution to this issue.

@eshwarmsft
Copy link
Contributor

eshwarmsft commented Apr 28, 2021

This issue will come when the permissions are not being inherited or approved after deploying the sharepoint package at the time of uploading from app catalogue. After doing the same able to update the profile picture with badge. Please let us know if you still see the same error even following the steps.

issue10
issue10_1
issue10_2
issue10_3

@yhabersaat
Copy link
Contributor

Redeployed the solution in the app catalog and approved the permissions, still not working:
image

@eshwarmsft
Copy link
Contributor

Thanks for trying the fix by redeploying and approving the permissions.

Sometimes the permissions take a little time to apply. Would you please take one more try by closing all the browsers and removing the existing profile image and try to update the profile pic from digital badge. If the issue still persists, Please provide the availability of call with screen share for better insights for us to troubleshoot if possible.

@Pratikd-msft
Copy link

Pratikd-msft commented May 12, 2021

@eshwarmsft @Smitat-msft - I am working with a customer who has the exact same issue. I verified the permission's for API access and they have been approved. Any idea on how do we fix the issue ? If you have time, I can setup a call with customer to troubleshoot.

@eshwarmsft
Copy link
Contributor

Hi @Pratikd-msft

Thanks for the update, There is no new permissions required if the cmp package is deployed with checkbox checked as shown
image and approved permissions as mentioned. Would you please try to remove the package and try to do install again with these two steps once again.
image

@Pratikd-msft
Copy link

@eshwarmsft We followed the steps of redeploying again and still facing the issue. Anything logs or anything else I can check.

@eshwarmsft
Copy link
Contributor

@Pratikd-msft Would you please give a try with the updated changes from version CMP 1.0.0.0

@jeff29922
Copy link

@eshwarmsft @Pratikd-msft is OOF on Paternity leave, I am backing him up and I am working with his customer on this issue. They have updated the app with the recommended changes, this has not fixed the issue. They are still having issues with updating the user profile with a badge. Can you please let me know of any logs/diagnostic data that I can pull and upload to help with troubleshooting this issue.

@jeff29922
Copy link

@Smitat-msft I am going to have my customer reproduce this issue with debug turned on in Edge. I will forward you the logs to review.

@v-saikirang
Copy link
Collaborator

Hi @UnknownNamez , @jeff29922 , @Pratikd-msft , @yhabersaat,

Thanks for your patience! We have updated the package to a new version V1.2 yesterday with few fixes and improvements. Can you please uninstall the existing package and try installing the new package from the same location - link.

You can see the updated ReadMe here for the 1.2 changelog and upgrading instructions as well under the section "Upgrade to version 1.2.0.0".

IMPORTANT NOTE: Please wait for 15 minutes after you have completed first 4 steps under the section "Upgrade to version 1.2.0.0" in ReadMe and then continue with step 5. This is to avoid cache related issues for the deleted assets.

@JoshLeporati JoshLeporati added help wanted Extra attention is needed and removed bug Something isn't working status: triaged for review labels Jul 23, 2021
@samuel-weber
Copy link

Hi. I created a PR (#49) fixing this problem. I had to set the crossOrigin to "Anonymous", allowing canvas handling different image-origins....

@v-saikirang
Copy link
Collaborator

Hi @samuel-weber,

We have already implemented this and it will be part of our next release. Thanks for sharing this.

Thanks.

@JoshLeporati JoshLeporati added the enhancement New feature or request label Aug 18, 2021
@JoshLeporati
Copy link
Contributor

As mentioned this will be addressed in an upcoming release, will update here when the release is available!

@JoshLeporati JoshLeporati removed the help wanted Extra attention is needed label Aug 18, 2021
@hkuu
Copy link

hkuu commented Oct 4, 2021

Was this already fixed? We are facing similar issues with the badge and it was mentioned earlier that "will update here when the release is available"?

@rajdeep1510
Copy link

rajdeep1510 commented Oct 28, 2021

Hi @JoshLeporati

I have deployed the latest version of the app. We had AD write back restrictions, but now it is resolved and users can change their Teams profile picture from Teams.

But we are getting an error on the app while applying the profile picture change, “There was an error applying the updated profile image to your account. Please try closing all browser windows and try again. If the error persists please start a new conversation on the General channel of the program's Team.”

I have tried to change the picture pixel to 91 x 91 pixels, checked the Teams client log, closed all browsers, teams and re-launched, but nothing yet worked.

Any advise to identify or troubleshoot the issue would really help.

Thanks,
Raj

@SjoerdV
Copy link

SjoerdV commented Nov 4, 2021

Same issue here (Champion user is also AD Synced btw)
solution version: 1.3.0.0
image

@v-saikirang
Copy link
Collaborator

Hi @rajdeep1510,

If you are fine, we can work on this troubleshooting offline. We can try out few fixes in your tenant. Can you please share your email ID and we can take this forward.
Thanks.

@rajdeep1510
Copy link

sure @v-saikirang, rajdeep1510@rediff.com

@v-saikirang
Copy link
Collaborator

Hi @SjoerdV,

Thanks for your patience. Please let me know if you are fine with troubleshooting this offline in your tenant. If you can share your Email we can work together on this.
Thanks.

@v-saikirang
Copy link
Collaborator

Hi @hkuu,

Please let us know if you want to try trouble shoot this in your tenant. If you can share your email we can take this forward and i can share further instructions.

Thanks.

@hkuu
Copy link

hkuu commented Dec 3, 2021

Hi @hkuu,

Please let us know if you want to try trouble shoot this in your tenant. If you can share your email we can take this forward and i can share further instructions.

Thanks.

Hi, could you share ideas for fixes here instead as it seems that our environment is not the only one where this badge is not working.

@v-saikirang

@Porkai-Pandian
Copy link
Collaborator

Closing out this issue, if the issue is still happening, please open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests