-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search results in chat box is cutting off tall items #1823
Comments
Hi catmanjan! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies. Best regards, Teams Platform |
@catmanjan - Thanks for raising this. We will check it and will get back to you shortly with our findings. |
@catmanjan - We checked this at our end in MS Teams desktop client
|
@Prasad-MSFT I seem to recall you couldn't reproduce the issue with one result in your search, in our case we have thousands See screenshot showing latest version and issue still occurs |
@catmanjan - As you can see in our case also the subtitle field text shows in single line below title text. This behaviour seems to be by design. |
@Prasad-MSFT try it but return 100 cards instead of just 1. |
@Prasad-MSFT if you look in my screenshot the number of lines of text that are shown is variable depending on how many lines the title is. I am sure you will be able to reproduce this if you returned several search results and compared how it displays to when you only return 1. |
@catmanjan - We have tried with multiple search results and if you can notice from each row, the first two lines are being occupied by title field, followed by one line of subtitle
|
How many was multiple? Try 100 |
@catmanjan - We have more than 30 search results |
@Prasad-MSFT do you have more than 99? |
No, it isn't. Do you mean to say it is not cutting off if the search result is nearly 30-40? Is it only showing cut off if its more than ~90? Did you check with ~30-40 search result? |
@Prasad-MSFT the behavior is different for a larger number of results - I don't know what that number is or why, it probably is related to whatever number Teams deems to be a "page" of results Try 100 results as I have suggested above THREE times now and let me know what you see. |
Okay @catmanjan, we will try that and also if you don't mind could you please share the code snippet which you are using having title, subtitle text having queryOptions to get more than 25 results (Currently by default is 25)? |
@Prasad-MSFT I don't have a code snippet, this is running in production |
@catmanjan - In our code we are able to see nearly 25 search results. We couldn't show more than that. It would have been great if we get the code which implements showing more than by default 25 search results. |
@Prasad-MSFT this is production code so I can't give you a snippet, can you just generate 100 results and trigger paging to occur? I don't think we do anything special for this to happen - Teams seems to just detect that there are more than a page of results and then only server the first page and do a second request to get additional ones... |
@catmanjan - We have used this code
and it gives nearly 25 results on search. We are not sure how to generate more than 100 results. Though we have implemented loop, still it returns default result. Could you please let us know the way you are implementing? Is it the same way? In response we are getting as below:
|
@Prasad-MSFT I can see you set Title and Subtitle but nowhere do you set the Text |
@catmanjan - That was the sample formatted code snippet which we shared just to show you how we are using loop to get more search results and adding pagination. Anyway, I have updated the actual code snippet which we are using, You can refer that. |
@Prasad-MSFT okay here is my equivalent function - not sure what you'll need to cherry pick from it to reproduce the issue though...
|
@Prasad-MSFT in our Text we have a Note that this behavior is different on the web version of Teams which shows as many lines as it needs... |
@catmanjan - I don't think |
@Prasad-MSFT yes the Teams desktop client only shows 4 lines maximum as my original screenshot shows - my web version of teams seems to impose no limit whatsoever and will show 20 lines... Here is the web version, and the desktop version is in the original ticket |
Yes @catmanjan - Looking at the provided screenshot it seems like it behaves differently in web and desktop client. |
@Prasad-MSFT no I can't - but I'm happy to be invited to a screen sharing session where I can let them take control of my machine. |
If that's not possible @catmanjan, please do share a screen record showing the behaviour of both web and desktop client, so that we can pass on that to engineering team. |
See attached, now its gone the other way - the web version shows less text than the desktop version,.... screen-recorder-fri-jul-28-2023-10-43-55.webm |
We have already raised bug with your previously provided screenshots. Now as per your response it behaves other way around. Thats quite strange |
bump |
HELLOOOOOO |
Apologies. We still haven't got any update from engineering team. We have updated the severity of the bug and hopefully will hear back soon from engineering team. Thanks! |
I logged this item before and it went away, but its happening again, we have search result cards which have Title, Subtitle, Text
If the Title is more than one line, the subtitle is cut off - it seems to be hardcoded to only show 4 lines
The text was updated successfully, but these errors were encountered: