Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the latest Edge or Chrome, Outlook on the Web does not show dialogs by displayDialogAsync when displayInIframe is true. #2129

Closed
3 tasks
t-miyake opened this issue Sep 18, 2021 · 26 comments
Assignees
Labels
Area: Outlook Issue related to Outlook add-ins Status: fixed Fix is deployed and available to customer Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs

Comments

@t-miyake
Copy link

Provide required information needed to triage your issue

Your Environment

  • Platform [PC desktop, Mac, iOS, Office on the web]: Office on the web
  • Host [Excel, Word, PowerPoint, etc.]: Outlook on the web
  • Office version number: ______
  • Operating System: Windows10
  • Browser (if using Office on the web): Microsoft Edge Version 93.0.961.52 and Google Chrome Version 93.0.4577.82

Expected behavior

This is the behavior with Outlook add in on send.

  1. Click the Send Email button in Outlook on the web.
  2. Outlook add in on send is executed and the dialog is displayed by Office.context.ui.displayDialogAsync.
    This is an excerpt from the Office.context.ui.displayDialogAsync part.
Office.context.ui.displayDialogAsync(dialogPath, { height: 60, width: 65, promptBeforeOpen: false, displayInIframe: true },
function (asyncResult) {
dialog = asyncResult.value;

Current behavior

The dialog is no longer displayed when using the latest stable versions of Edge or Chrome browsers.

  • Microsoft Edge version 93.0.961.52
  • Google Chrome version 93.0.4577.82

I have confirmed that the exact same add-in works fine in one previous version of Edge, 93.0.961.47.
Therefore, it could possibly be a problem on the browser side.

Steps to reproduce

This problem occurs when displayInIframe is true in an add-in for Outlook on the web that runs when sending.

In the above code, asyncResult.status will be "success", but Dialog will not be displayed.
I set displayInIframe and promptBeforeOpen to false, Dialog will be displayed normally in a separate window.

Context

The Dialog is displayed before the mail is sent, so if it is not displayed, the mail can no longer be sent.

Useful logs

  • Console errors
  • Screenshots
  • Test file (if only happens on a particular file)

Thank you for taking the time to report an issue. Our triage team will respond to you in less than 72 hours. Normally, response time is <10 hours Monday through Friday. We do not triage on weekends.

@ghost ghost added the Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP label Sep 18, 2021
@t-miyake
Copy link
Author

t-miyake commented Sep 18, 2021

I think this issue is due to the version of Outlook on the web, not the browser version.
I was mistaken because the timing was the same as the browser's version upgrade.

This issue occurs when version=20210913004.06.
However, if version=20210419002.11, this issue does not occur.

When I set displayInIframe to false, it works fine in 20210913004.06.
(The dialog is displayed correctly in a separate window, not inline.)
Therefore, I think 20210913004.06 may be the cause of the problem.

I have checked this version from the following URL.
20210913004 06

I have already added the targetOrigin property to messageParent and messageChild as described in this blog post.
(When tested with 20210913004.06. )
https://developer.microsoft.com/en-us/office/blogs/action-required-update-your-office-add-in-dialog-for-cross-domain-communication/

@t-miyake
Copy link
Author

I have tried a simple add-in for Outlook on the web for this issue.
Source code
https://github.com/t-miyake/OutlookOnSendAddinSample

Test Results
Both tests were conducted with Google Chrome version 93.0.4577.82.

Outlook on the web version 20210419002.11
(Only one of my PCs still loads 20210419002.11.)

  1. Create a new email
    Screenshot 2021-09-19 155932
  2. Edit the email and click the Send button.
  3. The dialog is displayed inline by the add-in.
    Screenshot 2021-09-19 155954

Outlook on the web version 20210913004.06

  1. Create a new email
    Screenshot 2021-09-19 165909
  2. Edit the email and click the Send button.
  3. The dialog will not appear and nothing will happen.
    Screenshot 2021-09-19 165923

I think Outlook on the web version 20210913004.06 has some problems when displayInIframe is true.
Since this is not an Issue by browser or its version, if it is more appropriate to change this title, I will do so.

@neville-jones
Copy link

neville-jones commented Sep 20, 2021

Observing similar problem and similar workaround but the workaround is only effective if have both
displayInIframe: false, promptBeforeOpen: false
So far in our testing, the workaround allows for the dialog to be shown (not in an iframe) but the ability to communicate back to the parent seems broken, even when parent and dialog are in the same domain.

The problem also occurs in Firefox 92.0 so is not browser specific.

@stefanoslig
Copy link

We also have the same issue! Most of the clients are affected by this. Is there any estimation on when there will be a fix for this issue?

@adamjlow
Copy link

We are having the same issue too, its having a major impact on our users!

@pinchukdiana
Copy link

@exextoc The issue has a major impact on our customers, can we get some attention to it, please?

@carlosb1504
Copy link

Similar issues here but not exactly the same. We are able to get dialogs to show from the taskpane but, regardless of whether displayInIframe is set to true or false, we can't seem to get any dialogs to display from the on-send hook, which is a major part of our implementation.

Any updates from anyone at MS regarding this?

@AlexJerabek
Copy link
Collaborator

Thank you for reporting this issue.

Assigning @exextoc to investigate and tagging @lliu113 to assist.

@AlexJerabek AlexJerabek added Area: Outlook Issue related to Outlook add-ins Needs: attention 👋 Waiting on Microsoft to provide feedback Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs and removed Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP labels Sep 20, 2021
@rickgoud
Copy link

@exextoc ; This change really braking every functionality that has pop-ups. Is this treated as a showstopper as it should? Seems that really no dialog works anymore?

@t-miyake
Copy link
Author

@exextoc This is a big issue for my clients (over 120,000 users).
If bug in the product, please announce it to users via Microsoft 365 Message center or Service health.

@neville-jones
Copy link

neville-jones commented Sep 20, 2021

Minor note, as indicated by @t-miyake you can use the following links to show the displayDialogAsync works with displayInIframe: true in the previous version, but which fails in current:

@albeiroespitia
Copy link

its-been-84-years

@adamjlow
Copy link

@exextoc are you able to provide any updates on this issue?

I can't express how severe the impact is on our users, is there anything we can to do raise the priority of this?

@exextoc exextoc added the Status: fix pending Fix is complete but awaiting prod deployment label Sep 21, 2021
@exextoc
Copy link
Collaborator

exextoc commented Sep 21, 2021

Apologies for the inconvenience caused.

The issue has been fixed and is being pushed out to production.
We will update the thread once the changes are pushed to 100% worldwide.

@adamjlow
Copy link

@exextoc how's the push going, has it reached 100% as we're not seeing the update ourselves?

@bdubaut
Copy link

bdubaut commented Sep 21, 2021

Apologies for the inconvenience caused.

The issue has been fixed and is being pushed out to production.
We will update the thread once the changes are pushed to 100% worldwide.

@exextoc Hi, I have a question regarding the deployment of the fix: there are multiple Office365 update channels:

  • current
  • Monthly
  • Semi-annual
  • Semi annual (preview)
  • Office insider program

Is the fix being deployed across all channels at once, or our customers that are on a semi-annual channel will need to wait until their next release to get the fix? As you might imagine, this would have a significant impact on our strategy of mitigating the issue should it persist with some customers.

Thanks!

@adamjlow
Copy link

adamjlow commented Sep 21, 2021

@exextoc really don't wish to be pushy but any update would be much appreciated.

@jgs-dev
Copy link

jgs-dev commented Sep 21, 2021

@exextoc 🙏🙏🙏

@neville-jones
Copy link

neville-jones commented Sep 21, 2021

Testing has not been successful, but we are not sure if our test tenancy has received the fix.

When we compose a new message, and click the icon in upper right to "Open in new window", the message is opened at URL
https://outlook.office.com/mail/deeplink/compose?popoutv2=1&version=20210913004.08
which is a different version compared to yesterday (https://outlook.office.com/mail/deeplink/compose?popoutv2=1&version=20210913004.06) but same problem as previously - the dialog is not shown.

@exextoc - can you provide details of the version number where we would expect to see the fix?

@t-miyake
Copy link
Author

I am in a similar situation to @neville-jones.
However, my computer 20210913004.09 is loaded and still not working properly.

Now I have found that the following version exists.
20210913004.10

And I have also confirmed that it works fine if I use this URL
https://outlook.office.com/mail/deeplink/compose?popoutv2=1&version=20210913004.10

@exextoc
I hope the problem is completely fixed in 20210913004.10 or newer.
It would be great if you could let us know the current status and the progress of the rollout.

@neville-jones
Copy link

Thanks @t-miyake ; my testing agrees.

Using URL
https://outlook.office.com/mail/deeplink/compose?popoutv2=1&version=20210913004.10
the dialog is successfully displayed in iframe mode.

@IvanFranic
Copy link

Thanks @t-miyake ; my testing agrees.

Using URL
https://outlook.office.com/mail/deeplink/compose?popoutv2=1&version=20210913004.10
the dialog is successfully displayed in iframe mode.

Hi Neville. The issue still exists in our tenant. We are unable to send any emails using JnausSeal App in OWA

@exextoc
Copy link
Collaborator

exextoc commented Sep 22, 2021

The issue has been fixed in production. Please let us know if it still reproduces.
Thanks a lot for the patience and we regret any inconvenience.

@exextoc exextoc added Status: fixed Fix is deployed and available to customer and removed Status: fix pending Fix is complete but awaiting prod deployment Needs: attention 👋 Waiting on Microsoft to provide feedback labels Sep 22, 2021
@t-miyake
Copy link
Author

@exextoc Thank you for fixing the issue!

@IvanFranic
Copy link

The issue has been fixed in production. Please let us know if it still reproduces.
Thanks a lot for the patience and we regret any inconvenience.

Thank you. I can confirm that the issue is resolved now in our Tenant :-)

@AlexJerabek
Copy link
Collaborator

Thanks for confirming @IvanFranic. I'll close the issue now, but please ping the thread or raise a new issue if anything is still amiss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Outlook Issue related to Outlook add-ins Status: fixed Fix is deployed and available to customer Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs
Projects
None yet
Development

No branches or pull requests