Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office.context.document.settings.saveAsync() disables undo #3141

Open
SharonCKC opened this issue Feb 10, 2023 · 8 comments
Open

Office.context.document.settings.saveAsync() disables undo #3141

SharonCKC opened this issue Feb 10, 2023 · 8 comments
Assignees
Labels
Area: Excel Issue related to Excel add-ins Status: under investigation Issue is being investigated Type: product feature request Office JS ideas that should be posted to aka.ms/m365dev-suggestions (formerly User Voice.)

Comments

@SharonCKC
Copy link

Your Environment

  • Host [Excel, Word, PowerPoint, etc.]: Excel

Provide additional details

The user makes some change to their data on a worksheet.
In the worksheet.onChanged event, first call Office.context.document.settings.set(key, value);
Then call Office.context.document.settings.saveAsync(). This makes sure that the setting is saved in the document for the next time that the user opens the doc. But saveAsync() disables the undo button.

Context

The add-in needs to update a setting whenever the user changes data (e.g. deletes a column). However, if the user accidentally deleted some data, they cannot recover it using undo.

Expected behavior

Two possible solutions. Either

  1. the undo button should not be disabled when Office.context.document.settings.saveAsync() is called
  2. Or please provide a workbook.onSave event. We need a better place to call Office.context.document.settings.saveAsync(). Then, we can continue to call settings.set() in the onChanged event, and only call settings.saveAsync() when the user saves the workbook.
@ghost ghost added the Area: Excel Issue related to Excel add-ins label Feb 10, 2023
@ghost ghost added the Needs: attention 👋 Waiting on Microsoft to provide feedback label Feb 10, 2023
@ghost
Copy link

ghost commented Feb 10, 2023

Thank you for letting us know about this issue. We will take a look shortly. Thanks.

@penglongzhaochina penglongzhaochina added Status: under investigation Issue is being investigated and removed Needs: attention 👋 Waiting on Microsoft to provide feedback labels Feb 16, 2023
@SiruiSun-MSFT
Copy link

Hi @SharonCKC ,
Thanks for reporting this issue. And the issue has been confirmed and tracked as ADO#7609487 in our backlog. Will share updates here if we have any progress!

@SharonCKC
Copy link
Author

@SiruiSun-MSFT any update? Undo is very important for data editing in Excel.

@SiruiSun-MSFT
Copy link

@SharonCKC, I'm sorry to tell you that this bug is still in the backlog. We will start the investigation ASAP when we have bandwidth. Or you can provide the scale of affected users, it will help us re-prioritize this bug. Thanks for your patience!

@SiruiSun-MSFT SiruiSun-MSFT added the Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs label Aug 31, 2023
@Isaac96SM
Copy link

same issue here, please fix it ASAP

@ValentinShtankoAimtraction

I have same issue here

@digambar2002
Copy link

is this issue solved? Can anybody found the solution

@SiruiSun-MSFT
Copy link

Thanks for your reporting here. We are tracking the progress of API Undo Support through Feature ASK. We recommend you to upvote or submit a new Tech Community New Ideas item, this will give us visibility of the commonality of it and will help with our prioritization. Once the timeline is lock down, will update here. Thanks again!

@SiruiSun-MSFT SiruiSun-MSFT added Type: product feature request Office JS ideas that should be posted to aka.ms/m365dev-suggestions (formerly User Voice.) and removed Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Excel Issue related to Excel add-ins Status: under investigation Issue is being investigated Type: product feature request Office JS ideas that should be posted to aka.ms/m365dev-suggestions (formerly User Voice.)
Projects
None yet
Development

No branches or pull requests

6 participants