-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Office.context.document.settings.saveAsync() disables undo #3141
Comments
Thank you for letting us know about this issue. We will take a look shortly. Thanks. |
Hi @SharonCKC , |
@SiruiSun-MSFT any update? Undo is very important for data editing in Excel. |
@SharonCKC, I'm sorry to tell you that this bug is still in the backlog. We will start the investigation ASAP when we have bandwidth. Or you can provide the scale of affected users, it will help us re-prioritize this bug. Thanks for your patience! |
same issue here, please fix it ASAP |
I have same issue here |
is this issue solved? Can anybody found the solution |
Thanks for your reporting here. We are tracking the progress of API Undo Support through Feature ASK. We recommend you to upvote or submit a new Tech Community New Ideas item, this will give us visibility of the commonality of it and will help with our prioritization. Once the timeline is lock down, will update here. Thanks again! |
Your Environment
Provide additional details
The user makes some change to their data on a worksheet.
In the
worksheet.onChanged
event, first callOffice.context.document.settings.set(key, value);
Then call
Office.context.document.settings.saveAsync()
. This makes sure that the setting is saved in the document for the next time that the user opens the doc. ButsaveAsync()
disables the undo button.Context
The add-in needs to update a setting whenever the user changes data (e.g. deletes a column). However, if the user accidentally deleted some data, they cannot recover it using undo.
Expected behavior
Two possible solutions. Either
Office.context.document.settings.saveAsync()
is calledworkbook.onSave
event. We need a better place to callOffice.context.document.settings.saveAsync()
. Then, we can continue to callsettings.set()
in theonChanged
event, and only callsettings.saveAsync()
when the user saves the workbook.The text was updated successfully, but these errors were encountered: