Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Some icons are missing #79

Closed
pascalberger opened this issue Sep 1, 2015 · 7 comments
Closed

Some icons are missing #79

pascalberger opened this issue Sep 1, 2015 · 7 comments

Comments

@pascalberger
Copy link

Some icons are not shown in the sample page. For example ms-Icon--onedrive, ms-Icon--thumbDown, ms-Icon--thumbUp, ms-Icon--officeThreshold, ms-Icon--office365, ms-Icon--office365Preview, etc

@LezaMax
Copy link
Contributor

LezaMax commented Sep 1, 2015

Working on it. I think icons that are not actually part of the release weren't removed from the CSS file. we will correct that soon.

@Jahnp
Copy link
Collaborator

Jahnp commented Sep 9, 2015

Yep, this was intentional and has been fixed for the next release. Basically, there were a number of brand-related icons we couldn't include for the release, but which were still used to test with internally. References to those icons have since been removed from the sample icons page. Thanks for the heads-up!

@andrewconnell
Copy link
Contributor

Looks like there are a few referenced in the CSS file that aren't there (seems the ones mentioned by @pascalberger were from the pre-1.0 release). The others I've found are:

@sidnc86
Copy link

sidnc86 commented Jan 24, 2017

ms-icon ms-icon--CloudDownload is another css class we are not getting in our Office Addin html page. The icon doesn't render. But on the other hand, ms-icon ms-icon--download does appear. Why does this happen?

@mikewheaton
Copy link
Contributor

@sidnc86: Based on the class names, it looks like you're using an older version of Fabric with the previous icon set. What you see documented on the icons page of the website is the MDL2 icon set. You can tell these icons by the UppercaseNames.

Which version of Fabric are you using?

@sidnc86
Copy link

sidnc86 commented Jan 25, 2017

Hey @mikewheaton - Thanks for quick and prompt response! We are using Fabric 2.6.0. Here's the URL to the css being referred - https://appsforoffice.microsoft.com/fabric/2.6.0/fabric.min.css

Hope this information helps.

@mikewheaton
Copy link
Contributor

Fabric 2.6.0 uses the previous "O365 Icons" set. You can find a list of all the icons in _Fabric.Icons.scss from the 2.6.2 branch. Hope that helps!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants