Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of clickable legends on line chart #10070

Merged
merged 4 commits into from Aug 7, 2019
Merged

Implementation of clickable legends on line chart #10070

merged 4 commits into from Aug 7, 2019

Conversation

atul4mlko
Copy link
Contributor

@atul4mlko atul4mlko commented Aug 6, 2019 •
edited

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Adds a click functionality to the line-chart legends.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@atul4mlko atul4mlko requested a review from Raghurk as a code owner August 6, 2019 18:07
@msftclas
Copy link

msftclas commented Aug 6, 2019 •
edited

CLA assistant check
All CLA requirements met.

@size-auditor
Copy link

size-auditor bot commented Aug 6, 2019

Size Auditor did not detect a change in bundle size for any component!

Raghurk
Raghurk approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@Raghurk Raghurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@msft-github-bot
Copy link
Contributor

Component Perf Analysis:

Scenario Master Samples * PR Samples *
BaseButton 756 728
BaseButton (experiments) 1035 1037
DefaultButton 1023 978
DefaultButton (experiments) 1964 1982
DetailsRow 4174 4200
DetailsRow without styles 3903 3938
DocumentCardTitle with truncation 30675 30410
MenuButton 1836 1859
MenuButton (experiments) 3864 3926
PrimaryButton 1113 1133
PrimaryButton (experiments) 1962 1986
SplitButton 3256 3214
SplitButton (experiments) 7202 7314
Stack 466 472
Stack with Intrinsic children 1068 1062
Stack with Text children 4128 4193
Text 367 363
Toggle 794 818
Toggle (experiments) 2244 2164
button 50 55
* Sample counts can vary by up to 30% and shouldn't be used solely for determining regression. For more information please see the Perf Testing wiki.

@marygans marygans merged commit 860cbdd into microsoft:master Aug 7, 2019
@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v0.134.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.21.0 has been released which incorporates this pull request.:tada:

Handy links:

@atul4mlko atul4mlko deleted the clickable-linechart branch August 7, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@marygans marygans

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atul4mlko @msftclas @msft-github-bot @Raghurk @marygans