Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withResponsiveMode: reverting previous change that broke some scenarios. #10763

Merged
merged 5 commits into from Oct 9, 2019
Merged

withResponsiveMode: reverting previous change that broke some scenarios. #10763

merged 5 commits into from Oct 9, 2019

Conversation

dzearing
Copy link
Member

@dzearing dzearing commented Oct 9, 2019 •
edited

This change reverts defaulting to "unknown" in cases where we don't preemptively know the screen size.

This should address scenarios where not rendering the content fast enough is causing breaking changes.

For example:

DialogContent is not rendered fast enough, so setting focus to the initial value is not happening.
Dropdown is not rendered fast enough, so componentRef is not resolved before parent mount.

Microsoft Reviewers: Open in CodeFlow

@size-auditor
Copy link

size-auditor bot commented Oct 9, 2019 •
edited

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react ContextualMenu 144.847 kB 144.867 kB ExceedsBaseline     20 bytes
office-ui-fabric-react DocumentCard 197.519 kB 197.539 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Pivot 170.163 kB 170.183 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Dialog 190.003 kB 190.023 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Dropdown 212.356 kB 212.376 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Panel 181.812 kB 181.832 kB ExceedsBaseline     20 bytes
office-ui-fabric-react CommandBar 183.631 kB 183.651 kB ExceedsBaseline     20 bytes
office-ui-fabric-react ComboBox 224.582 kB 224.602 kB ExceedsBaseline     20 bytes
office-ui-fabric-react SearchBox 170.839 kB 170.859 kB ExceedsBaseline     20 bytes
office-ui-fabric-react SelectedItemsList 211.213 kB 211.233 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Nav 171.786 kB 171.806 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Modal 90.258 kB 90.278 kB ExceedsBaseline     20 bytes
office-ui-fabric-react MessageBar 172.909 kB 172.929 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Facepile 193.482 kB 193.502 kB ExceedsBaseline     20 bytes
office-ui-fabric-react FloatingPicker 220.977 kB 220.997 kB ExceedsBaseline     20 bytes
office-ui-fabric-react SpinButton 176.25 kB 176.27 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Button 177.093 kB 177.113 kB ExceedsBaseline     20 bytes
office-ui-fabric-react SwatchColorPicker 174.972 kB 174.992 kB ExceedsBaseline     20 bytes
office-ui-fabric-react TeachingBubble 175.979 kB 175.999 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Breadcrumb 181.77 kB 181.79 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Grid 164.852 kB 164.872 kB ExceedsBaseline     20 bytes
office-ui-fabric-react Pickers 261.829 kB 261.849 kB ExceedsBaseline     20 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: f55e1a0a167b3752d6f64166cceefdfcd0c573a4 (build)

@khmakoto khmakoto changed the title withResponsieMode: reverting previous change that broke some scenarios. withResponsiveMode: reverting previous change that broke some scenarios. Oct 9, 2019
@msft-github-bot
Copy link
Contributor

Component Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 783 729
BaseButton (experiments) 1038 1038
DefaultButton 1005 1093
DefaultButton (experiments) 2025 1977
DetailsRow 3373 3444
DetailsRow (fast icons) 3240 3213
DetailsRow without styles 3098 3051
DocumentCardTitle with truncation 30825 30924
MenuButton 1372 1409
MenuButton (experiments) 3694 3731
PrimaryButton 1228 1251
PrimaryButton (experiments) 2101 2042
SplitButton 2879 2943
SplitButton (experiments) 7221 7186
Stack 488 490
Stack with Intrinsic children 1113 1090
Stack with Text children 4373 4381
Text 379 381
Toggle 810 875
Toggle (experiments) 2307 2288
button 51 65

@dzearing dzearing merged commit 8a9e4e0 into microsoft:master Oct 9, 2019
@dzearing dzearing deleted the revert-responsive-mode-change branch October 9, 2019 21:42
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.47.0 has been released which incorporates this pull request.:tada:

Handy links:

dzearing added a commit that referenced this pull request Oct 10, 2019
@dzearing
withResponsiveMode: reverting previous change that broke some scenari…
5da90f2 
…os. (#10763) (#10769)

* Updating responsivemode fix to default to large if none is provided.

* Change files

* Tweaking logic to default to last mode rather than large every time.

* snapshots.
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v6.208.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

Assignees

@khmakoto khmakoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dzearing @msft-github-bot @khmakoto