DetailList: Screen Reader is reading wrong column header with associated cell value for single-select list #11365
Conversation
xugao
requested review from
dzearing,
natalieethell,
ThomasMichon and
micahgodbolt
Asset size changes
Baseline commit: 953d773faf8a24bbcfecf9e39a2f5f371c9e5c49 (build) |
Component Perf AnalysisNo significant results to display. All results
|
|
Can you share screenshots of what it looks like before and after? If there's a visual difference this may be something we need to run by design. |
|
@ecraig12345 - there is no visual diff caused by this change. the element i removed style from is empty. |
There was a problem hiding this comment.
Signing-off. The style change LGTM since there is no visual regression when manually removing style when selectAllVisibility={SelectAllVisibility.hidden} is provided via onRenderDetailsHeader, see: https://codepen.io/kevintcoughlin/pen/QWwyxRq?&editable=true.
|
🎉 Handy links: |
Pull request checklist
$ yarn changeDescription of changes
aria-colindexis not being respected when narrator is reading the header name for each row value. (the multi-line cross-reference scenario).This issue seems to something lacking by narrator. Here is a minimal repro in codepen to better demo this bug & my fix: https://codepen.io/xugao/pen/WNbNaVW
The fix I can find is to not hide the empty checkbox header column. Then narrator will count it as a column by default, and header name will be correct since header row has same number of columns as other rows.
Microsoft Reviewers: Open in CodeFlow