Button: fix size mismatch between primary and default buttons #11366
Conversation
Asset size changes
Baseline commit: 9f3391062f8f862986c54612a25c6702ebc6cf36 (build) |
Component Perf AnalysisNo significant results to display. All results
|
|
this is causing a small change with high contrast mode before
after
Can you make sure that borders are picking up the high contrast background as well |
|
Also, the change in border is affecting the appearance of the focus state before:
after
Not 100% sure the 'after' there is wrong. but it's a change. @betrue-final-final what's your take on the focus styles with that extra pixel border? |
|
It actually makes it a little clearer. I'm good with this. Would Default also look like this with the extra padding? |
|
better view of side by side |
|
Ben is good with the new focus rec......i'd say just clean up high contrast and we're good |
xugao
force-pushed
the
xgao/button-style-fix
branch
from
163a64c
to
a93ddbe
Compare
|
Forgot to hit send. Yes this is great. |
|
@xugao I think we also need to adjust the border of primary buttons in High Contrast when the buttons are hovered and pressed. |
|
high contrast is looking great now
|
|
🎉 Handy links: |
Pull request checklist
$ yarn changeDescription of changes
Fix bug where primary & default buttons with same child have different sizes due to primary one has no border but default one does.
Microsoft Reviewers: Open in CodeFlow