Fabric: Properly handle dir being passed into control #11626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahgodbolt
changed the title
Component Perf AnalysisNo significant results to display. All results
|
2 tasks
jdhuntington
approved these changes
Jan 8, 2020
|
@dzearing are you good with this change? |
dzearing
reviewed
Jan 10, 2020
| const divProps = getNativeProps<React.HTMLAttributes<HTMLDivElement>>(this.props, divProperties, ['dir']); | ||
| // If dir is set via props, use that value, otherwise if theme is set, use theme RTL setting, otherwise, set undefined. | ||
| const htmlDir = | ||
| dir !== undefined ? dir : theme !== undefined && theme.rtl !== undefined ? (theme.rtl === true ? 'rtl' : 'ltr') : undefined; |
There was a problem hiding this comment.
minor nit but I think this could be a little more readable:
const themeDir = (theme && theme.rtl) ? 'rtl' : 'ltr';
const htmlDir = dir !== undefined ? dir : themeDir;
micahgodbolt
requested review from
aneeshack4,
atneik,
Jahnp,
JasonGore,
joschect,
ThomasMichon and
Vitalius1
as code owners
|
per david's suggestion, the dir logic is a bit more simple and will always return RTL or LTR for a Fabric component. |
Asset size changes
Baseline commit: 61d9d19cb20855cc6d2930a4764ff397a3cf1bc4 (build) |
|
had to do a bit more work to account for page level RTL (which does not affect theme). Reworked a bit of my and Davids Customizer logic to be a bit easier to follow. Specifically here: https://github.com/OfficeDev/office-ui-fabric-react/pull/11626/files#diff-3b229796dd0781151c4cb54697913f02R21 |
aneeshack4
approved these changes
Jan 10, 2020
dzearing
approved these changes
Jan 13, 2020
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
Earlier Fabric component update set
direction: rtlbased off of the theme alone. This update will look first to thedirattribute (if provided), and then look to the theme.rtl (if provided) before settingdirattribute of the Fabric component.Updated tests as well.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow