Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scheduled signal #12008

Merged
merged 4 commits into from Feb 20, 2020
Merged

add scheduled signal #12008

merged 4 commits into from Feb 20, 2020

Conversation

amshan15
Copy link
Contributor

@amshan15 amshan15 commented Feb 20, 2020 •
edited by msft-github-bot

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

ecraig12345
ecraig12345 requested changes Feb 20, 2020
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

packages/experiments/package.json Outdated Show resolved Hide resolved
@msft-github-bot
Copy link
Contributor

Component Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 685 680
BaseButton (experiments) 860 793
DefaultButton 962 935
DefaultButton (experiments) 1748 1780
DetailsRow 3169 3081
DetailsRow (fast icons) 3239 3234
DetailsRow without styles 2942 2906
DocumentCardTitle with truncation 1600 1561
MenuButton 1233 1219
MenuButton (experiments) 3265 3312
PrimaryButton 1064 1091
PrimaryButton (experiments) 1826 1820
SplitButton 2708 2664
SplitButton (experiments) 6645 6625
Stack 432 434
Stack with Intrinsic children 1026 994
Stack with Text children 3750 3816
Text 352 344
Toggle 770 744
Toggle (experiments) 2131 2068
button 74 61

@size-auditor
Copy link

size-auditor bot commented Feb 20, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 748de606b106afa50c24cca9af7a228caed6b8bf (build)

@msft-github-bot
Copy link
Contributor

Hello @ecraig12345!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@msft-github-bot msft-github-bot merged commit b91a397 into microsoft:master Feb 20, 2020
@amshan15 amshan15 deleted the amshan/addScheduledSignal branch February 20, 2020 20:58
@msft-github-bot
Copy link
Contributor

🎉@uifabric/experiments@v7.20.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@dzearing dzearing Awaiting requested review from dzearing

@kenotron kenotron Awaiting requested review from kenotron

Assignees

@aneeshack4 aneeshack4

Labels
AutoMerge Package: experiments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amshan15 @msft-github-bot @ecraig12345 @aneeshack4