Fluent : carousel accessibility fixes #12050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGore
previously requested changes
Feb 26, 2020
There was a problem hiding this comment.
Just an FYI, packages/fluentui is virtually read-only until the fluent repo is archived and the final import of code is completed. I will block this PR for now until that point just for added safety.
Also, CODEOWNERS was updated to add fluent repo members, but that wasn't in place yet when you created this PR. You can just manually assign reviewers for this specific PR.
|
This PR looks like it succumbed to github issues that were occurring last night so I will close and reopen to trigger a new build. |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e5c9f2bea83a4b9b0a82d303682c2ea093036c83 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
kolaps33
requested review from
dzearing,
ecraig12345,
jdhuntington,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
|
@kolaps33 Any updates on this? |
jurokapsiar
reviewed
Mar 4, 2020
packages/fluentui/docs/src/examples/components/Carousel/BestPractices/CarouselBestPractices.tsx
Outdated
Show resolved
Hide resolved
jurokapsiar
reviewed
Mar 4, 2020
packages/fluentui/docs/src/examples/components/Carousel/BestPractices/CarouselBestPractices.tsx
Show resolved
Hide resolved
jurokapsiar
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created based on the from another repository:
https://github.com/microsoft/fluent-ui-react/pull/2278/files
Related carousel: Carousel with Pagination
In this PR are fixes related to the feedback which we got from Rekha + feedback from testing.
Issue: Index numbers (1 of 4) are read twice as you down arrow through the carousel item.
Fix: add aria-hidden="true" on the text
2.1 Issue: The first and the last item in the carousel are not read when the prev/next button is pressed in browse mode.
2.2 #2224
Fix: moving focusing the next/previous paddle to generic function, which is call always, even when "onclick" is executed...
Issue: Should there be focus on the entire carousel control and the left/right buttons? Seems redundant and adds more keyboard stops
Fix: change the behavior that for carousel without the "tab" navigation there will be tabindex=-1 on itemsContainer
Issue: Carousel itself should have a label property defined. The roledescription is set to “Carousel” so label can be “Portrait collection” for this example
Fix: added prop aria-label to be able label the carousel
Issue: #2225
Fix: was decided that if reader will narrate "carousel" user will know how to use keyboard to rotate through the carousel
For this reason to narrate "carousel" in application mode was added additional props(role, aria-label,aria-roledescription) into "itemsContainer" in "carouselBehavior.ts".
Now there is role "group". After more testing could be change for "region". For me region was not narrating "carousel" in focus mode for NVDA.
Issue: Programmatically Prev/Next buttons are outside carousel container so it will likely confuse the user. Carousel container element should include all elements within carousel.
Fix: apply region only for "Carousel with Pagination", provide there proper label and roledescription. Fix is in "carouselBehavior.ts" for "root" slot.
Microsoft Reviewers: Open in CodeFlow