chore: refactor Flex to be functional component [v0] #12078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3d5fba42e42c72fe33dd2ce54cdda2e1cd940835 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
ecraig12345
added
the
Fluent UI react-northstar (v0)
layershifter
commented
Feb 27, 2020
| children: PropTypes.oneOfType([PropTypes.element, PropTypes.func]), | ||
|
|
||
| align: PropTypes.oneOf(['auto', 'start', 'end', 'center', 'baseline', 'stretch']), | ||
| size: PropTypes.oneOfType([PropTypes.oneOf(['size.half', 'size.quarter', 'size.small', 'size.medium', 'size.large']), PropTypes.string]), |
There was a problem hiding this comment.
Previously was incorrect 💣
…OfficeDev/office-ui-fabric-react into chore/flex-to-fc � Conflicts: � packages/fluentui/CHANGELOG.md
layershifter
changed the title
mnajdova
reviewed
Feb 28, 2020
| static defaultProps = { | ||
| as: 'div' | ||
| }; | ||
| const content = React.Children.map(children, child => { |
There was a problem hiding this comment.
Let's refactor this with adding FlexContextProvider
There was a problem hiding this comment.
Agree, can we do this thing separately? I want to make a small showcase from it
mnajdova
reviewed
Feb 28, 2020
| children: PropTypes.oneOfType([PropTypes.element, PropTypes.func]), | ||
|
|
||
| align: PropTypes.oneOf(['auto', 'start', 'end', 'center', 'baseline', 'stretch']), | ||
| size: PropTypes.oneOfType([PropTypes.oneOf(['size.half', 'size.quarter', 'size.small', 'size.medium', 'size.large']), PropTypes.string]), |
There was a problem hiding this comment.
A bit worried that this can be any css value (px or %) which may cause problems with the caching... :(
There was a problem hiding this comment.
Let's see the feedback. I agree there that it can be a real issue, but:
- I don't think that it's used enough frequently
sizemanagesflexBasis, may be in this case we should manage it viadesignprop...- we can disable caching for
FlexItem
…c-react into chore/flex-to-fc � Conflicts: � packages/fluentui/CHANGELOG.md
mnajdova
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeBREAKING CHANGES
This PR converts
Flex&FlexItemcomponents to be functional. As in all other cases it contains a breaking change with restricted props set that will be passed to styles functions.Prop sets
FlexcolumndebugfillgaphAligninlinepaddingspacevAlignwrapFlexItemaligngrowflexDirectionpushshrinksizeMicrosoft Reviewers: Open in CodeFlow