chore: Moving ToolbarMenuItem to be functional component

[pompomon]

Pull request checklist

• Addresses an existing issue: Fixes #0000
• Include a change request file using $ yarn change

Breaking changes

This PR converts ToolbarMenuItem component to be functional. As in all other cases it contains a breaking change with restricted props set that will be passed to styles functions.

ToolbarMenuItem
disabled

Microsoft Reviewers: Open in CodeFlow

[msft-github-bot]

Perf Analysis

No significant results to display.

All results

Scenario	Master Ticks	PR Ticks	Status
BaseButton	767	744
BaseButton (experiments)	960	979
DefaultButton	1069	1032
DefaultButton (experiments)	1984	1925
DetailsRow	3539	3464
DetailsRow (fast icons)	3430	3510
DetailsRow without styles	3293	3284
DocumentCardTitle with truncation	1522	1526
MenuButton	1400	1381
MenuButton (experiments)	3526	3595
PrimaryButton	1199	1221
PrimaryButton (experiments)	2054	2051
SplitButton	2919	2873
SplitButton (experiments)	6964	6989
Stack	483	487
Stack with Intrinsic children	1142	1168
Stack with Text children	4252	4289
Text	369	369
Toggle	877	840
Toggle (experiments)	2239	2304
button	62	59

Perf Analysis (Fluent)

Perf comparison

Status	Scenario	Fluent TPI	Fabric TPI	Ratio	Iterations	Ticks
🔧	Avatar.Fluent	0.55	0.52	1.06:1	2000	1096
🦄	Button.Fluent	0.16	0.24	0.67:1	1000	157
🔧	Checkbox.Fluent	0.94	0.39	2.41:1	1000	941
🔧	Dialog.Fluent	0.39	0.24	1.63:1	5000	1957
🔧	Dropdown.Fluent	3.84	0.53	7.25:1	1000	3844
🔧	Icon.Fluent	0.19	0.05	3.8:1	5000	937
🎯	Image.Fluent	0.08	0.11	0.73:1	5000	387
🔧	Slider.Fluent	1.62	0.42	3.86:1	1000	1615
🔧	Text.Fluent	0.08	0.02	4:1	5000	398
🦄	Tooltip.Fluent	0.12	15.86	0.01:1	5000	614

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
RefMinimalPerf.default	205	180	1.14:1
ButtonMinimalPerf.default	169	158	1.07:1
PopupMinimalPerf.default	457	429	1.07:1
Image.Fluent	387	361	1.07:1
ImageMinimalPerf.default	359	339	1.06:1
TextMinimalPerf.default	383	362	1.06:1
DialogMinimalPerf.default	2023	1925	1.05:1
LabelMinimalPerf.default	391	373	1.05:1
Button.Fluent	157	150	1.05:1
AlertMinimalPerf.default	663	635	1.04:1
AnimationMinimalPerf.default	732	706	1.04:1
Avatar.Fluent	1096	1058	1.04:1
AvatarMinimalPerf.default	598	579	1.03:1
ChatMinimalPerf.default	622	603	1.03:1
HierarchicalTreeMinimalPerf.default	1170	1136	1.03:1
ListMinimalPerf.default	470	458	1.03:1
ProviderMergeThemesPerf.default	1352	1319	1.03:1
Icon.Fluent	937	907	1.03:1
DropdownMinimalPerf.default	3873	3815	1.02:1
HeaderSlotsPerf.default	1907	1866	1.02:1
ListWith60ListItems.default	184	181	1.02:1
LoaderMinimalPerf.default	1103	1077	1.02:1
TooltipMinimalPerf.default	893	874	1.02:1
TreeMinimalPerf.default	1272	1248	1.02:1
TreeWith60ListItems.default	273	267	1.02:1
Slider.Fluent	1615	1582	1.02:1
BoxMinimalPerf.default	339	336	1.01:1
ButtonSlotsPerf.default	772	766	1.01:1
CarouselMinimalPerf.default	2147	2127	1.01:1
FlexMinimalPerf.default	541	538	1.01:1
ListCommonPerf.default	1074	1068	1.01:1
ListNestedPerf.default	975	968	1.01:1
RadioGroupMinimalPerf.default	621	613	1.01:1
TextAreaMinimalPerf.default	3357	3318	1.01:1
Dialog.Fluent	1957	1946	1.01:1
DropdownManyItemsPerf.default	363	362	1:1
HeaderMinimalPerf.default	624	627	1:1
MenuMinimalPerf.default	2208	2206	1:1
MenuButtonMinimalPerf.default	2048	2048	1:1
VideoMinimalPerf.default	997	1002	1:1
Dropdown.Fluent	3844	3826	1:1
AccordionMinimalPerf.default	276	280	0.99:1
AttachmentSlotsPerf.default	3706	3741	0.99:1
DividerMinimalPerf.default	1114	1126	0.99:1
GridMinimalPerf.default	953	959	0.99:1
ItemLayoutMinimalPerf.default	2312	2331	0.99:1
SegmentMinimalPerf.default	1261	1273	0.99:1
SliderMinimalPerf.default	1569	1581	0.99:1
CustomToolbarPrototype.default	3854	3880	0.99:1
ToolbarMinimalPerf.default	1209	1220	0.99:1
Checkbox.Fluent	941	947	0.99:1
AttachmentMinimalPerf.default	968	990	0.98:1
EmbedMinimalPerf.default	6400	6512	0.98:1
FormMinimalPerf.default	1044	1062	0.98:1
IconMinimalPerf.default	418	426	0.98:1
InputMinimalPerf.default	1057	1082	0.98:1
LayoutMinimalPerf.default	756	769	0.98:1
ProviderMinimalPerf.default	634	645	0.98:1
ReactionMinimalPerf.default	2637	2684	0.98:1
SplitButtonMinimalPerf.default	13086	13297	0.98:1
StatusMinimalPerf.default	350	356	0.98:1
ChatDuplicateMessagesPerf.default	443	455	0.97:1
TableMinimalPerf.default	748	772	0.97:1
Text.Fluent	398	409	0.97:1
CheckboxMinimalPerf.default	4177	4333	0.96:1
Tooltip.Fluent	614	642	0.96:1
PortalMinimalPerf.default	308	328	0.94:1
ChatWithPopoverPerf.default	610	703	0.87:1

[size-auditor]

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5366fcd5f97f1bd8117509e67dfdca7157d744aa (build)