chore(Toolbar): convert ToolbarDivider, ToolbarCustomItem & ToolbarItem to functional components #12161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em to functional components
layershifter
requested review from
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny,
mnajdova,
pompomon and
silviuaavram
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
mnajdova
reviewed
Mar 3, 2020
| @@ -39,9 +40,9 @@ export default toolbarItemBehavior; | |||
|
|
|||
| export type ToolbarItemBehaviorProps = { | |||
| /** Indicated if toolbar item has a menu. */ | |||
| menu?: boolean | object; | |||
| hasMenu?: boolean; | |||
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
mnajdova
reviewed
Mar 3, 2020
packages/fluentui/react/src/components/Toolbar/ToolbarDivider.tsx
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Mar 3, 2020
mnajdova
reviewed
Mar 3, 2020
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a724c8b57e290179f95db3f64759d4a11132a234 (build) |
pompomon
reviewed
Mar 3, 2020
| @@ -46,49 +46,70 @@ export interface ToolbarCustomItemProps extends UIComponentProps, ChildrenCompon | |||
| onBlur?: ComponentEventHandler<ToolbarCustomItemProps>; | |||
| } | |||
|
|
|||
| class ToolbarCustomItem extends UIComponent<WithAsProp<ToolbarCustomItemProps>> { | |||
| static displayName = 'ToolbarCustomItem'; | |||
| export type ToolbarCustomItemStylesProps = Required<Pick<ToolbarCustomItemProps, 'fitted'>>; | |||
There was a problem hiding this comment.
Please, why do you set 'fitted' as a required style prop?
Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
…thub.com/OfficeDev/office-ui-fabric-react into chore/toolbar-cmpts-to-fc
pompomon
approved these changes
Mar 3, 2020
layershifter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeBREAKING CHANGES
This PR converts
ToolbarDivider,ToolbarCustomItem&ToolbarItemcomponents to be functional. As in all other cases it contains a breaking change with restricted props set that will be passed to styles functions.Prop sets
ToolbarDividerToolbarCustomItemfittedToolbarItemactivedisabledMicrosoft Reviewers: Open in CodeFlow