Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding proper border color for Menu #12171

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Adding proper border color for Menu #12171

merged 2 commits into from
Mar 6, 2020

Conversation

notandrew
Copy link
Member

@notandrew notandrew commented Mar 3, 2020

Adding the correct color border to Menu:

before:
image

after:
image

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Mar 3, 2020

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 654 669
BaseButton (experiments) 943 852
DefaultButton 929 957
DefaultButton (experiments) 1790 1818
DetailsRow 3169 3272
DetailsRow (fast icons) 3140 3222
DetailsRow without styles 2992 3013
DocumentCardTitle with truncation 1549 1552
MenuButton 1237 1254
MenuButton (experiments) 3283 3265
PrimaryButton 1101 1115
PrimaryButton (experiments) 1824 1835
SplitButton 2666 2626
SplitButton (experiments) 6638 6586
Stack 443 381
Stack with Intrinsic children 1037 1053
Stack with Text children 3802 3706
Text 335 367
Toggle 777 773
Toggle (experiments) 2103 2084
button 65 56

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.5 0.49 1.02:1 2000 1007
🦄 Button.Fluent 0.15 0.23 0.65:1 1000 149
🔧 Checkbox.Fluent 0.9 0.35 2.57:1 1000 904
🔧 Dialog.Fluent 0.35 0.22 1.59:1 5000 1750
🔧 Dropdown.Fluent 3.55 0.47 7.55:1 1000 3545
🔧 Icon.Fluent 0.16 0.05 3.2:1 5000 790
🦄 Image.Fluent 0.06 0.1 0.6:1 5000 288
🔧 Slider.Fluent 1.56 0.36 4.33:1 1000 1564
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 340
🦄 Tooltip.Fluent 0.12 18.27 0.01:1 5000 580

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
StatusMinimalPerf.default 306 251 1.22:1
InputMinimalPerf.default 1085 969 1.12:1
BoxMinimalPerf.default 320 291 1.1:1
LabelMinimalPerf.default 346 323 1.07:1
PortalMinimalPerf.default 288 270 1.07:1
RefMinimalPerf.default 208 196 1.06:1
TreeWith60ListItems.default 229 217 1.06:1
ButtonSlotsPerf.default 741 707 1.05:1
ListNestedPerf.default 954 911 1.05:1
AnimationMinimalPerf.default 633 606 1.04:1
ListCommonPerf.default 975 939 1.04:1
LoaderMinimalPerf.default 1105 1065 1.04:1
AttachmentMinimalPerf.default 967 943 1.03:1
CheckboxMinimalPerf.default 4135 4021 1.03:1
EmbedMinimalPerf.default 6563 6361 1.03:1
HierarchicalTreeMinimalPerf.default 1047 1020 1.03:1
ListMinimalPerf.default 387 376 1.03:1
SliderMinimalPerf.default 1638 1592 1.03:1
Tooltip.Fluent 580 565 1.03:1
DropdownMinimalPerf.default 3664 3597 1.02:1
GridMinimalPerf.default 871 851 1.02:1
MenuButtonMinimalPerf.default 1936 1899 1.02:1
TooltipMinimalPerf.default 842 826 1.02:1
Dropdown.Fluent 3545 3487 1.02:1
AccordionMinimalPerf.default 248 246 1.01:1
CarouselMinimalPerf.default 2115 2090 1.01:1
DialogMinimalPerf.default 1770 1755 1.01:1
DropdownManyItemsPerf.default 351 347 1.01:1
IconMinimalPerf.default 377 372 1.01:1
ProviderMinimalPerf.default 689 679 1.01:1
RadioGroupMinimalPerf.default 528 521 1.01:1
ToolbarMinimalPerf.default 1079 1068 1.01:1
Checkbox.Fluent 904 896 1.01:1
Icon.Fluent 790 784 1.01:1
AvatarMinimalPerf.default 564 566 1:1
ButtonMinimalPerf.default 137 137 1:1
LayoutMinimalPerf.default 669 669 1:1
ListWith60ListItems.default 194 194 1:1
ReactionMinimalPerf.default 2517 2527 1:1
SplitButtonMinimalPerf.default 12838 12886 1:1
TextMinimalPerf.default 325 326 1:1
CustomToolbarPrototype.default 3921 3919 1:1
VideoMinimalPerf.default 926 930 1:1
Button.Fluent 149 149 1:1
Slider.Fluent 1564 1566 1:1
Text.Fluent 340 341 1:1
AlertMinimalPerf.default 599 607 0.99:1
AttachmentSlotsPerf.default 3581 3628 0.99:1
FormMinimalPerf.default 940 950 0.99:1
HeaderSlotsPerf.default 1621 1642 0.99:1
ProviderMergeThemesPerf.default 1328 1347 0.99:1
MenuMinimalPerf.default 2014 2058 0.98:1
TreeMinimalPerf.default 1147 1168 0.98:1
ChatMinimalPerf.default 517 534 0.97:1
ChatWithPopoverPerf.default 581 597 0.97:1
DividerMinimalPerf.default 972 998 0.97:1
TableMinimalPerf.default 643 661 0.97:1
TextAreaMinimalPerf.default 3249 3339 0.97:1
Avatar.Fluent 1007 1033 0.97:1
Dialog.Fluent 1750 1795 0.97:1
ChatDuplicateMessagesPerf.default 406 423 0.96:1
HeaderMinimalPerf.default 544 564 0.96:1
ItemLayoutMinimalPerf.default 2077 2154 0.96:1
PopupMinimalPerf.default 387 403 0.96:1
SegmentMinimalPerf.default 1104 1149 0.96:1
FlexMinimalPerf.default 253 267 0.95:1
ImageMinimalPerf.default 287 312 0.92:1
Image.Fluent 288 312 0.92:1

@size-auditor
Copy link

size-auditor bot commented Mar 3, 2020

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 53510c2

Possible causes

  • The baseline build 53510c2 is broken
  • The Size Auditor run for the baseline build 53510c2 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@notandrew notandrew closed this Mar 6, 2020
@notandrew notandrew reopened this Mar 6, 2020
@notandrew notandrew merged commit da69ede into microsoft:master Mar 6, 2020
@notandrew notandrew deleted the fix/menucolor branch March 6, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants