-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add disabled version for Dropdown and Input #12250
feat: add disabled version for Dropdown and Input #12250
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1d135a297eaa4e2859e68fbd500d49cb3f4016af (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
...s/fluentui/docs/src/examples/components/Dropdown/State/DropdownExampleDisabled.shorthand.tsx
Outdated
Show resolved
Hide resolved
...s/fluentui/docs/src/examples/components/Dropdown/State/DropdownExampleDisabled.shorthand.tsx
Outdated
Show resolved
Hide resolved
packages/fluentui/react/src/themes/teams/components/Dropdown/dropdownStyles.ts
Outdated
Show resolved
Hide resolved
I was looking on the PR. Checkout the branch and was looking on it with screen readers, it looks good :) But it looked for me suspicious that we need to stop propagate events in "onClick", as I would suppose event is not invoked. |
Pull request checklist
$ yarn change
Description of changes
Provides
disabled
behavior forDropdown
and also forInput
(because we are usingInput
forDropdownSearchInput
).predefinedProps
ifdisabled
is true.disabled
prop on nativeinput
andbutton
.disabled
to Downshift so it does not give us handlers anymore.Added examples in docsite for both components and also unit tests.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow